Skip to content

[BUG] diff is inconsistent in comparing prerelease to later versions #561

Closed
#566
Closed
[BUG] diff is inconsistent in comparing prerelease to later versions#561
#566
Labels
Bugthing that needs fixingPriority 1high priority issue

Description

@pgsandstrom
pgsandstrom
opened on May 26, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

This code:

    console.log(diff('2.0.0-alpha.1', '2.0.0'))
    console.log(diff('2.0.0-alpha.1', '2.1.1'))

Results in "major" and "minor".

Expected Behavior

The code should result in the output "major", "major".

Steps To Reproduce

Just run the code with semver v7.5.1. The bug seems to have appeared in 7.4.0.

Environment

  • npm: 8.18.0
  • Node: v18.8.0
  • OS: Windows 11
  • platform: node

Activity

  1. pgsandstrom
    added
    Bugthing that needs fixing
    Needs Triageneeds an initial review
    on May 26, 2023
  2. lukekarrys
    added 2 commits that reference this issue on Jun 15, 2023

    fix: diff when detecting major change from prerelease

    56c8411

    fix: diff when detecting major change from prerelease

    e5856da
  3. lukekarrys
    added
    Priority 1high priority issue
    and removed
    Needs Triageneeds an initial review
    on Jun 15, 2023
  4. lukekarrys
    closed this as completedin #566on Jun 15, 2023
  5. lukekarrys
    added a commit that references this issue on Jun 15, 2023

    fix: diff when detecting major change from prerelease (#566)

    58c791f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bugthing that needs fixingPriority 1high priority issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions