Repository navigation
fix: deflake cache-fastimers-fix.js - #4491
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the flakyness of test/interceptors/cache-fastimers-fix.js and renames the filename to a more descriptive name cache-revalidate-statel.js. Also "fastimers" is a clear typo.
The flakyness was due to the fact, that the http-server by nodejs is sending the date header, which is not overridable by modifying the global Date and/or Timer Logic. I guess node core also caches the date and refreshes it every second and not on every http request?! That resulted in the flakyness, we saw.
I basically deactivated sending the date header via the http server and send my own mocked date header t. Thus making it fully deterministic.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status