Repository navigation
WebSocket fires both close and error events twice if the socket is closed before being opened. #4628
Description
Reproducible By
import { WebSocket } from "undici";
const ws = new WebSocket("wss://example.com/");
ws.onopen = () => {
console.log("Opened", ws.readyState);
}
ws.onclose = () => {
console.log("Closed", ws.readyState);
}
ws.onerror = () => {
console.log("error", ws.readyState);
}
setTimeout(() => {
ws.close();
}, 100); // Modify this value to ensure the closing happens before or after opening
Expected output
error 2
Closed 3
Actual output
error 3
Closed 3
error 3
Closed 3
Environment
- ArchLinux
- nodejs v24.9.0
- undici ^7.16.0
Activity
fix: prevent duplicate error and close events in WebSocket
KhafraDev commentedon Oct 18, 2025
In other environments I get
Why do you expect the state to be CLOSING (2) when emitting the error event?
zbinlin commentedon Oct 19, 2025
In
wspackage, the readyState is 2.KhafraDev commentedon Oct 19, 2025
I think this is the same as #4487 (comment), or at least close to it. The readyState being CLOSING seems to be correct and makes more sense.