You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would be amazing, but it'd also be somewhat feasible to create it outside of this module. I recommend that route at this point as we are stretched really thin.
If no one is working on it I am interested in picking it up, as I am working on nodejs/node#57165 I think it would be a great addition for Node.js built fetch to work more seamlessly with socks 5 proxies. The lack of support of it was one of the reasons I added the local README config in node-core-utils as a workaround (because if you try to fetch github raw content within Chinese GFW you get connection issues). It would also help closing nodejs/node-core-utils#653 and overall making Node.js easier to use for developers in China (socks5 is very popular in China).
Reacted by Carlos Fuentes, Khafra, JsonSong89, Gerald, firengate, LucCADORET, Li Yi, beyondkmp and jinsong
Reacted by Alessandro Miliucci, firengate, cluah, LucCADORET, beyondkmp, yfunk and idranme
Activity
mcollina commentedon Aug 24, 2023
This would be amazing, but it'd also be somewhat feasible to create it outside of this module. I recommend that route at this point as we are stretched really thin.
idranme commentedon Aug 24, 2023
It would be best if it could be integrated in this module.
mcollina commentedon Aug 24, 2023
PRs are welcomed.
KhafraDev commentedon Aug 25, 2023
have you tried https://github.com/Kaciras/fetch-socks?
idranme commentedon Aug 25, 2023
https://github.com/Kaciras/fetch-socks/blob/master/package.json#L34
This package depends on an undici. So I don't think it's ideal.
KhafraDev commentedon Aug 25, 2023
the caret means it supports undici versions of at least 5.22.1
idranme commentedon Aug 26, 2023
When I use undici, it installs one more on its side, which will now will exist two undici.
KhafraDev commentedon Sep 5, 2023
you can probably use dedupe
PandaWorker commentedon Sep 9, 2023
Wouldn't it be simpler to make a buildConnector for each type of proxy and use it as a connector?
Or you can do it the same way as done by aiohttp in python (https://github.com/Slzdude/aiohttp-proxy)
eugenepugach commentedon Nov 9, 2023
Also after implementation SOCKS5 - we have got CRITICAL Vulnerability ❌ CVE-2023-38545 which affected on the security.
joyeecheung commentedon Mar 5, 2025
If no one is working on it I am interested in picking it up, as I am working on nodejs/node#57165 I think it would be a great addition for Node.js built fetch to work more seamlessly with socks 5 proxies. The lack of support of it was one of the reasons I added the local README config in node-core-utils as a workaround (because if you try to fetch github raw content within Chinese GFW you get connection issues). It would also help closing nodejs/node-core-utils#653 and overall making Node.js easier to use for developers in China (socks5 is very popular in China).
metcoder95 commentedon Mar 7, 2025
Go for it, I believe hasn't been progress since then
feat: implement SOCKS5 proxy support (Phase 1)
grepsuzette commentedon Sep 8, 2025
Not just
socks5://but alsosocks5h, for dns resolution through the proxy, which is often critical.AffiTheCreator commentedon Dec 22, 2025
Hi Team,
Thanks for all your hard work!
Just a friendly reminder from a happy user: would it be possible to share an update on when PR #4385 will be merged?
Thanks again!
feat: implement SOCKS5 proxy support (Phase 1)
feat: implement SOCKS5 proxy support (Phase 1)
feat: add SOCKS5 proxy support to ProxyAgent (#4385)