nodejs-dependency-vuln-assessments automation failing #1181

Activity

1. richardlau commented on Jan 4, 2024

   

   richardlau

   on Jan 4, 2024

   Last edited by richardlau

   Member

   More actions

   It is failing to parse the version of brotli after nodejs/node#50804
   BROTLI_VERSION is now defined as

   #define BROTLI_VERSION BROTLI_MAKE_HEX_VERSION(                     \
     BROTLI_VERSION_MAJOR, BROTLI_VERSION_MINOR, BROTLI_VERSION_PATCH)
   

   instead of as a hex string. (note that BROTLI_VERSION_MAJOR, BROTLI_VERSION_MINOR, and BROTLI_VERSION_PATCH do not exist in earlier versions of brotli.)
2. richardlau commented on Jan 4, 2024

   

   richardlau

   on Jan 4, 2024

   Member

   More actions

   PR: nodejs/nodejs-dependency-vuln-assessments#171
3. richardlau commented on Jan 4, 2024

   

   richardlau

   on Jan 4, 2024

   Member

   More actions

   The update script for brotli also needs to be fixed for the same reason.
   PR: nodejs/node#51373
4. richardlau

   closed this as completedin nodejs-dependency-vuln-assessments#171on Jan 5, 2024
5. nodejs-github-bot

   added a commit that references this issue on Jan 7, 2024

   tools: fix version parsing in brotli update script

   ...

   15b38fa
6. marco-ippolito

   added a commit that references this issue on Jan 12, 2024

   tools: fix version parsing in brotli update script

   ...

   c63f465
7. Medhansh404

   added a commit that references this issue on Jan 19, 2024

   tools: fix version parsing in brotli update script

   ...

   54cda22
8. targos

   added a commit that references this issue on Feb 15, 2024

   tools: fix version parsing in brotli update script

   ...

   29492e2