Repository navigation
http2: shouldUpgradeCallback is not a function with allowHTTP1 in v22.21.0 #60336
Description
Version
v22.21.0
Platform
Darwin MAC-202307007 25.0.0 Darwin Kernel Version 25.0.0: Wed Sep 17 21:35:32 PDT 2025; root:xnu-12377.1.9~141/RELEASE_ARM64_T6020 arm64
Subsystem
http2
What steps will reproduce the bug?
I'm experiencing this issue through Vite 7.1.11 with HTTPS options.
vite.config.ts:
import * as fs from 'node:fs'
import { defineConfig } from 'vitest/config'
export default defineConfig({
server: {
https: {
key: fs.readFileSync('./key.pem'),
cert: fs.readFileSync('./cert.pem'),
},
},
})Steps:
- Generate a self-signed certificate:
- Run
npx vite - Access https://localhost:5173 in browser
Error:
VITE v7.1.11 ready in 111 ms
➜ Local: https://localhost:5173/
➜ Network: use --host to expose
node:_http_server:1076
!!server.shouldUpgradeCallback(req);
^
TypeError: server.shouldUpgradeCallback is not a function
at parserOnIncoming (node:_http_server:1076:28)
at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
Node.js v22.21.0
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior? Why is that the expected behavior?
The server should handle HTTP/1.1 Upgrade requests (like WebSocket handshake) without errors.
What do you see instead?
The server crashes immediately when the first HTTP/1.1 Upgrade request is received:
TypeError: server.shouldUpgradeCallback is not a function
at parserOnIncoming (node:_http_server:1076:28)
at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
The server terminates and the upgrade request is never processed.
Additional information
This works fine on Node.js v22.20.0 and below. The issue appeared after upgrading to v22.21.0, where PR #59824 was backported but the fix PR #59924 (which has dont-land-on-v22.x label) was not.
Activity
0tarof commentedon Oct 21, 2025
I experienced same issue, and should be fixed in v22.21.1 or later.
Martin-Luther commentedon Oct 21, 2025
I am having the same issue with v22.21.0
TheSeg commentedon Oct 21, 2025
I'm also experiencing the same issue via Vite as described with same versions and repo steps.
The following is out of scope to the Node project, but including it for reference until the patch is released:
When using NVM and a project defining
lts/jodin.nvmrc, NVM will keep upgrading to v22.21. You'll have to manually replacelts/jodwith22.20in order to continue work.pimterry commentedon Oct 23, 2025
This was fixed in #60341, and should be released in v22.21.1 in the coming days (watch this space: #60375).
1YalcinSahin1 commentedon Oct 27, 2025
I'm experiencing the same issue. We're waiting for a solution.
sglenns commentedon Oct 27, 2025
The PR should be this one #59924 which is on its way to 22.21.1 (#60375)
pimterry commentedon Oct 30, 2025
Fixed in v22.21.1, which has now been released.
Froyo30 commentedon Oct 30, 2025
Muchas gracias, solo he podido darme cuenta del error por ti!!!✌️
feat(billing): Paddle checkout — сторінка /billing/pay, cancel для re…