Skip to content

test: test-tick-processor failed #5903

Closed
Closed
test: test-tick-processor failed#5903
Labels
macosIssues and PRs related to the macOS platform.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@ghaiklor
ghaiklor
opened on Mar 25, 2016
  • Version: v6.0.0-pre
  • Platform: Darwin Kernel Version 15.4.0
  • Subsystem: test

When running make test, I got the following:

/usr/bin/python tools/test.py --mode=release message parallel sequential -J
=== release test-tick-processor ===
Path: parallel/test-tick-processor
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at runTest (/Users/ghaiklor/Library/Projects/node/test/parallel/test-tick-processor.js:58:3)
    at Object.<anonymous> (/Users/ghaiklor/Library/Projects/node/test/parallel/test-tick-processor.js:38:1)
    at Module._compile (module.js:417:34)
    at Object.Module._extensions..js (module.js:426:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:451:10)
    at startup (node.js:155:18)
    at node.js:433:3
Command: out/Release/node /Users/ghaiklor/Library/Projects/node/test/parallel/test-tick-processor.js
[00:55|% 100|+ 1062|-   1]: Done
make: *** [test] Error 1

Assertion error in this code:

runTest(/RunInDebugContext/,
  `function f() {
     require(\'vm\').runInDebugContext(\'Debug\');
     setImmediate(function() { f(); });
   };
   setTimeout(function() { process.exit(0); }, 2000);
   f();`);

Activity

  1. mscdex
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    macosIssues and PRs related to the macOS platform.
    on Mar 25, 2016

  2. thefourtheye commented on Mar 26, 2016

    @thefourtheye
    thefourtheye
    on Mar 26, 2016
    Contributor

    I wonder why this is not caught in CI.

  3. Trott commented on Mar 26, 2016

    @Trott
    Trott
    on Mar 26, 2016
    Member

    I wonder why this is not caught in CI.

    The test already has open issues for it being flaky on two other platforms. It is a non-deterministic test that will vary a lot based on how powerful your computer is, so that's probably what's going on here.

  4. balupton commented on Mar 27, 2016

    @balupton
    balupton
    on Mar 27, 2016

    Getting the same here on OSX 10.11.4 (15E65)

    14:39:14:balupton@balmac.local:/Users/balupton/Projects/uni/node:(HEAD detached at v5.9.1)
$ make test
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
make[1]: Nothing to be done for `all'.
ln -fs out/Release/node node
Running main() from gtest_main.cc
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from UtilTest
[ RUN      ] UtilTest.ListHead
[       OK ] UtilTest.ListHead (0 ms)
[----------] 1 test from UtilTest (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 1 test.
/usr/local/opt/python/bin/python2.7 tools/test.py --mode=release message parallel sequential -J
=== release test-tick-processor ===                                            
Path: parallel/test-tick-processor
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at runTest (/Users/balupton/Projects/uni/node/test/parallel/test-tick-processor.js:58:3)
    at Object.<anonymous> (/Users/balupton/Projects/uni/node/test/parallel/test-tick-processor.js:38:1)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:142:18)
    at node.js:939:3
Command: out/Release/node /Users/balupton/Projects/uni/node/test/parallel/test-tick-processor.js
[00:58|% 100|+ 1046|-   1]: Done                                               
make: *** [test] Error 1

  5. balupton commented on Mar 27, 2016

    @balupton
    balupton
    on Mar 27, 2016

    There is also #4427 for the same test file - not sure if it is related.

  6. Trott commented on Mar 27, 2016

    @Trott
    Trott
    on Mar 27, 2016
    Member

    /cc @nodejs/v8

  7. indutny commented on Mar 27, 2016

    @indutny
    indutny
    on Mar 27, 2016
    Member

    I got this too

  8. indutny commented on Mar 27, 2016

    @indutny
    indutny
    on Mar 27, 2016
    Member

    I believe this is a culprit:

    $ foo() { nm "$@" | (c++filt -p -i || cat) }; foo $@ -n -f /Users/findutnyy/Code/indutny/node/out/Release/node
nm: for the -format option: Cannot find option named '/Users/findutnyy/Code/indutny/node/out/Release/node'!

    Looking...

  9. indutny commented on Mar 27, 2016

    @indutny
    indutny
    on Mar 27, 2016
    Member

    Fix:

    diff --git a/deps/v8/tools/tickprocessor.js b/deps/v8/tools/tickprocessor.js
index 600d2ee..ccdb11e 100644
--- a/deps/v8/tools/tickprocessor.js
+++ b/deps/v8/tools/tickprocessor.js
@@ -757,8 +757,10 @@ inherits(MacCppEntriesProvider, UnixCppEntriesProvider);
 MacCppEntriesProvider.prototype.loadSymbols = function(libName) {
   this.parsePos = 0;
   libName = this.targetRootFS + libName;
+
+  // It seems that with OS X 10.11.4, `nm` thinks that `-f` is a format option
   try {
-    this.symbols = [os.system(this.nmExec, ['-n', '-f', libName], -1, -1), ''];
+    this.symbols = [os.system(this.nmExec, ['-n', libName], -1, -1), ''];
   } catch (e) {
     // If the library cannot be found on this system let's not panic.
     this.symbols = '';

    Going to submit it to V8 team.

  10. indutny commented on Mar 27, 2016

    @indutny
    indutny
    on Mar 27, 2016
    Member

    CL: https://codereview.chromium.org/1840633002/

  11. matthewloring commented on Mar 27, 2016

    @matthewloring
    matthewloring
    on Mar 27, 2016

    @indutny The test still passes on my end with your fix applied.

  12. ghaiklor commented on Mar 27, 2016

    @ghaiklor
    ghaiklor
    on Mar 27, 2016
    ContributorAuthor

    @matthewloring @indutny on my end too. Issue can be closed.

  13. 22 remaining items

  14. Trott commented on Apr 28, 2016

    @Trott
    Trott
    on Apr 28, 2016
    Member

    This is surprising to me, but git bisect flags 204f3a8 as the commit that introduces the problem.

    Can someone else compile that commit on OS X and confirm that ./node test/parallel/test-tick-processor.js fails? And then compile dd67608 (the immediately prior commit) and confirm that the same test succeeds?

    /cc @ChALkeR @ofrobots @thealphanerd

  15. Trott commented on Apr 28, 2016

    @Trott
    Trott
    on Apr 28, 2016
    Member

    Looks like that 204f3a8 was landed without a CI run, so if it really is the culprit, that explains why CI didn't catch the problem. :-/

  16. bnoordhuis commented on Apr 28, 2016

    @bnoordhuis
    bnoordhuis
    on Apr 28, 2016
    Member

    It looks like the test is failing due to new ASLR features that MACOSX_DEPLOYMENT_TARGET=10.7 enables. If you build with make LINK="c++ -Wl,-no_pie", the test starts passing again.

  17. indutny commented on Apr 28, 2016

    @indutny
    indutny
    on Apr 28, 2016
    Member

    @bnoordhuis thank you, this is indeed matches my observations.

    (And sorry everyone, I was distracted)

  18. bnoordhuis
    added a commit that references this issue on Apr 28, 2016

    build: unbreak -prof, disable PIE on OS X

    cc0d71f

  19. bnoordhuis commented on Apr 28, 2016

    @bnoordhuis
    bnoordhuis
    on Apr 28, 2016
    Member

    #6453 for a proposed (hopefully temporary) workaround.

  20. jasnell
    closed this as completedin a5012a0on Apr 29, 2016
  21. MylesBorins
    added a commit that references this issue on May 3, 2016

    deps: cherry-pick 1383d00 from v8 upstream

    6416ebb
  22. Fishrock123
    added a commit that references this issue on May 4, 2016

    build: unbreak -prof, disable PIE on OS X

    7153f96
  23. MylesBorins
    added a commit that references this issue on May 6, 2016

    deps: cherry-pick 1383d00 from v8 upstream

    7456fb1
  24. MylesBorins
    added a commit that references this issue on May 18, 2016

    deps: cherry-pick 1383d00 from v8 upstream

    433fb9a
  25. sjarmak
    added a commit that references this issue on Jul 27, 2026

    build: unbreak -prof, disable PIE on OS X

    a5012a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    macosIssues and PRs related to the macOS platform.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions