Repository navigation
Make util.isArray() EOL #58013
Description
util.isArray() was the sole util.is* type-checking method left over from #52744. The remainder are all EOL as of v23.0.0.
It looks like the motivation for leaving this at the time was to allow for its use to be removed from the form-data library, which it has since been.
Is there another motivation for leaving this as-is, or can it now be made EOL?
cc: @marco-ippolito
Activity
anonrig commentedon Apr 25, 2025
Can you open a pull-request?
marco-ippolito commentedon Apr 25, 2025
I remember there were other libraries affected, we need to run citgm
miguelmarcondesf commentedon Apr 25, 2025
I can take a look if you want to @Renegade334
Renegade334 commentedon Apr 25, 2025
Sure, if you fancy.
Could also experiment with running citgm against removing
util._extend(), as the other surviving graduate of #50488, although I suspect that legacy debug dependencies will still be an issue there.jasnell commentedon Apr 25, 2025
This is one I'm less convinced that we can do. I still encounter a fair number of
util.isArray(...)calls in third party dependencies.ljharb commentedon Apr 25, 2025
fwiw if it's a small enough list, then like form-data, i could attempt to steward them and maximally backport a change.
Renegade334 commentedon Jul 27, 2025
The original question has effectively been answered in the linked PR, so I'll close this unless there's a strong desire to keep a tracking issue.
marco-ippolito commentedon Jul 28, 2025
I'm okay with keeping the issue open, someone might want to give it a try in a a few months/next year, and hopefully the situation has changed
BridgeAR commentedon Sep 12, 2025
I think closing this for now is actually better than keeping it around since this is not a crucial issue. We can still open a new one in a few years.