Repository navigation
rsa-oaep decrypt the ciphertext (an empty string) got an unexpected string #57553
Description
Version
23.7.0
Platform
Windows, macOS, Linux
Subsystem
crypto
What steps will reproduce the bug?
the crypto.privateDecrypt method sames changed the behavior since node23.7. I'm not sure that is a bug or feature. Reproduce codes as below:
// file: test-crypto-private-decrypt.js
const crypto = require('crypto');
const keys = crypto.generateKeyPairSync(
'rsa',
{
modulusLength: 2048,
publicKeyEncoding: { type: 'spki', format: 'pem' },
privateKeyEncoding: { type: 'pkcs8', format: 'pem' },
}
);
const empty = '';
const ciphertext = crypto.publicEncrypt({
oaepHash:'sha1',
padding: crypto.constants.RSA_PKCS1_OAEP_PADDING,
key: keys.publicKey,
}, Buffer.from(empty)).toString('base64');
const plaintext = crypto.privateDecrypt({
oaepHash: 'sha1',
padding: crypto.constants.RSA_PKCS1_OAEP_PADDING,
key: keys.privateKey
}, Buffer.from(ciphertext, 'base64')).toString('utf8');
console.assert(empty === plaintext, 'rsa-oaep `encrypt` empty string is success, but `decrypt` got unexpected string.');when run the code, such as node test-crypto-private-decrypt.js in node23.7.0. The terminal prompted the message:
Assertion failed: rsa-oaep `encrypt` empty string is success, but `decrypt` got unexpected string.
How often does it reproduce? Is there a required condition?
no extra conditions.
What is the expected behavior? Why is that the expected behavior?
the privateDecrypt behavior should be same as before >= 10 < 23.7
What do you see instead?
Assertion failed: rsa-oaep encrypt empty string is success, but decrypt got unexpected string.
Additional information
The failed CI was here, message as below:
1) lib/rsa
Rsa::decrypt
method `decrypt` should returns an empty string when `ciphertext` is the input via `Rsa.encrypt` and `privateKeyCertificate` is a `pem` buffer:
AssertionError: expected '\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000' to be empty
at Assertion.fail (node_modules/should/cjs/should.js:275:17)
at Assertion.value [as empty] (node_modules/should/cjs/should.js:356:19)
at Context.<anonymous> (tests/lib/rsa.test.js:120:68)
at process.processImmediate (node:internal/timers:511:21)
2) lib/rsa
Rsa::decrypt
method `decrypt` should returns an empty string when `ciphertext` is the input via `Rsa.encrypt` and `privateKeyCertificate` is a pkcs8 `pem` String:
AssertionError: expected '\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000' to be empty
at Assertion.fail (node_modules/should/cjs/should.js:275:17)
at Assertion.value [as empty] (node_modules/should/cjs/should.js:356:19)
at Context.<anonymous> (tests/lib/rsa.test.js:135:68)
at process.processImmediate (node:internal/timers:511:21)
Activity
panva commentedon Mar 20, 2025
I can confirm this regressed in v23.7.0
Likely suspects #56653, #56526, or #56421
@jasnell can you please take a look? #56653 is the most likely since it did not land on 22.x and the issue is not present in the latest 22.x but it could be a interaction of the three as well.
[-]since v23.7, ras-oaep decrypt the ciphertext (plain of the empty string) got an expected string[/-][+]since v23.7, ras-oaep decrypt the ciphertext (plain of the empty string) got an unexpected string[/+]AmitPrajapati-1 commentedon Mar 20, 2025
I've updated the PR with the requested changes. Please review when possible. #57558
AmitPrajapati-1 commentedon Mar 21, 2025
can you check this PR #57572
crypto: fix output of privateDecrypt with zero-length data
[-]since v23.7, ras-oaep decrypt the ciphertext (plain of the empty string) got an unexpected string[/-][+]rsa-oaep decrypt the ciphertext (an empty string) got an unexpected string[/+]crypto: fix output of privateDecrypt with zero-length data
crypto: fix output of privateDecrypt with zero-length data
crypto: fix output of privateDecrypt with zero-length data