Skip to content

Config file schema link is a 404 #57485

Closed
nodejs/release-cloudflare-worker
#331

Description

@cjihrig

The new config file docs link to https://nodejs.org/node-config-schema.json, which is a 404.

Activity

  1. AugustinMauroy commented on Mar 16, 2025

    @AugustinMauroy
    Member

    Where did you get this link ? because on nodejs.org we didn't serve that.

  2. cjihrig commented on Mar 16, 2025

    @cjihrig
    ContributorAuthor

    It is linked from this section of the docs: https://nodejs.org/api/cli.html#--experimental-config-fileconfig

  3. AugustinMauroy commented on Mar 16, 2025

    @AugustinMauroy
    Member

    cc @nodejs/web-infra I think this need to be handle by r2/worker ?
    maybe point to lasted LTS ?

  4. MattIPv4 commented on Mar 16, 2025

    @MattIPv4
    Member

    What generates this file? Is it an artifact of the release process, the API docs build process, something else?

  5. flakey5 commented on Mar 16, 2025

    @flakey5
    Member

    Yeah I think the worker should be handling this as well, it is part of the release assets https://nodejs.org/dist/v23.10.0/docs/node-config-schema.json.

    I'm not sure on how this file is being generated at all, but it does look like a new feature as of 3 days ago.

  6. AugustinMauroy commented on Mar 16, 2025

    @AugustinMauroy
    Member

    I'm not sure on how this file is being generated at all, but it does look like a new feature as of 3 days ago.

    function generateConfigJsonSchema() {

    https://github.com/nodejs/node/blob/0cfc471e8288addb6f4d927e8711d507b81e2eeb/tools/doc/generate-json-schema.mjs

  7. ovflowd commented on Mar 16, 2025

    @ovflowd
    Member

    It is not our fault if core adds a new file that is expected to be served but does not notify either the build team or the web infra team to ensure that this gets synced over and available 😅 (assuming we did not get reached out as this is the first time Im hearing of this)

  8. ovflowd commented on Mar 16, 2025

    @ovflowd
    Member

    The links are working fine? The only one that does not work is the one linking directly to nodejs.org root and that requires some sort of aliasing. Because all doc links or api links are under /doc or /api -- so we should have been requested to at least make this happen 😅

    + what should this alias point towards? The same version available when you do nodejs.org/api?

  9. added a commit that references this issue on Mar 16, 2025
    3ba934f
  10. flakey5 commented on Mar 16, 2025

    @flakey5
    Member
    • what should this alias point towards? The same version available when you do nodejs.org/api?

    I believe so, /api is where it's being referenced anyways

  11. added
    configIssues and PRs related to Node.js configuration and feature settings.
    on Mar 17, 2025
  12. marco-ippolito commented on Mar 17, 2025

    @marco-ippolito
    Member

    Woopsie 😅 I forgot to ping the web infra team

  13. flakey5 commented on Mar 18, 2025

    @flakey5
    Member

    This should be fixed now

  14. cjihrig commented on Mar 18, 2025

    @cjihrig
    ContributorAuthor

    Thanks!

  15. ovflowd commented on Mar 18, 2025

    @ovflowd
    Member

    Woopsie 😅 I forgot to ping the web infra team

    All good! Props to @cjihrig for creating this issue 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    configIssues and PRs related to Node.js configuration and feature settings.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions