You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should plan to unflag node:sqlite, as it has been flagged for a while and we plan to use it in Undici to provide an HTTP cache store: nodejs/undici#3657.
I think at a minimum there should be some performance work done prior to unflagging because it will likely involve changing the compilation settings. See this comment.
It's probably worth asking @tniessen as well, as they have made several changes that would become semver majors if unflagged.
(Note, I will be slow to respond for the next day or so.)
Activity
mcollina commentedon Nov 14, 2024
@cjihrig what's missing?
cjihrig commentedon Nov 14, 2024
I think at a minimum there should be some performance work done prior to unflagging because it will likely involve changing the compilation settings. See this comment.
It's probably worth asking @tniessen as well, as they have made several changes that would become semver majors if unflagged.
(Note, I will be slow to respond for the next day or so.)
mcollina commentedon Nov 14, 2024
Oh I mean to keep it experimental with a warning on usage, just unflagging it.
cjihrig commentedon Nov 15, 2024
Oh. I'd be happy to see the flag go. +1.
doc,lib,src,test: unflag sqlite module
doc,lib,src,test: unflag sqlite module
doc,lib,src,test: unflag sqlite module
doc,lib,src,test: unflag sqlite module