Skip to content

Unflag node:sqlite #55854

Closed
Closed

Description

@mcollina

I think we should plan to unflag node:sqlite, as it has been flagged for a while and we plan to use it in Undici to provide an HTTP cache store: nodejs/undici#3657.

Activity

  1. mcollina commented on Nov 14, 2024

    @mcollina
    SponsorMemberAuthor

    @cjihrig what's missing?

  2. cjihrig commented on Nov 14, 2024

    @cjihrig
    Contributor

    I think at a minimum there should be some performance work done prior to unflagging because it will likely involve changing the compilation settings. See this comment.

    It's probably worth asking @tniessen as well, as they have made several changes that would become semver majors if unflagged.

    (Note, I will be slow to respond for the next day or so.)

  3. mcollina commented on Nov 14, 2024

    @mcollina
    SponsorMemberAuthor

    Oh I mean to keep it experimental with a warning on usage, just unflagging it.

  4. added
    discussIssues opened for discussion and feedback.
    experimentalIssues and PRs related to experimental features.
    sqliteIssues and PRs related to the SQLite subsystem.
    on Nov 14, 2024
  5. cjihrig commented on Nov 15, 2024

    @cjihrig
    Contributor

    Oh. I'd be happy to see the flag go. +1.

  6. added a commit that references this issue on Nov 19, 2024
  7. added a commit that references this issue on Nov 26, 2024
  8. added a commit that references this issue on Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussIssues opened for discussion and feedback.experimentalIssues and PRs related to experimental features.sqliteIssues and PRs related to the SQLite subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions