napi is missing method to create buffer from ArrayBuffer

What is the problem this feature will solve?

Not possible to create Buffer from ArrayBuffer with napi

What is the feature you are proposing to solve the problem?

Add signature similar to what we have for typed arrays:

napi_status napi_create_typedarray(napi_env env,
                                   napi_typedarray_type type,
                                   size_t length,
                                   napi_value arraybuffer,
                                   size_t byte_offset,
                                   napi_value* result)

napi_status napi_create_buffer(napi_env env,
                               size_t length,
                               napi_value arraybuffer,
                               size_t byte_offset,
                               napi_value* result)

What alternatives have you considered?

No response

@ronag

Would like to work on it , and discuss more on it
I think his feature would bring the API in line with the existing napi_create_typedarray function
@ronag @redyetidev

@ronag

We already have a functionin in src/node_api.cc , should we update this function or create new one with different name
@ronag @redyetidev
like to discuss on these 2 also , like reference and structure if already done for any other module
// Get the underlying ArrayBuffer data
// Create a Buffer from the ArrayBuffer

napi_status NAPI_CDECL napi_create_buffer(napi_env env,
                                          size_t length,
                                          void** data,
                                          napi_value* result) {
  NAPI_PREAMBLE(env);

napi_create_buffer_from_array_buffer or something?

Though the same name regarding the other 2 points have any idea ?

Please use

napi_status node_api_create*

That is, the prefix should not be napi_ for new APIs, but node_api_.

node-api: add napi_create_buffer_from_arraybuffer method

Navigation Menu

Repository navigation

napi is missing method to create buffer from `ArrayBuffer` #54440

What is the problem this feature will solve?

What is the feature you are proposing to solve the problem?

What alternatives have you considered?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

napi is missing method to create buffer from ArrayBuffer #54440

Description

What is the problem this feature will solve?

What is the feature you are proposing to solve the problem?

What alternatives have you considered?

Activity

shubhamsugara22 commented on Aug 20, 2024

shubhamsugara22 commented on Aug 21, 2024

ronag commented on Aug 21, 2024

shubhamsugara22 commented on Aug 21, 2024

gabrielschulhof commented on Sep 13, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

napi is missing method to create buffer from `ArrayBuffer` #54440