v8::String::Value is deprecated #54417

Activity

1. targos commented on Aug 17, 2024

   

   targos

   on Aug 17, 2024

   MemberAuthor

   More actions

   Here are the places where we use it:

   
   [51/238] CXX obj/src/libnode.node_buffer.o
   ../../src/node_buffer.cc:969:19: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
       String::Value needle_value(isolate, needle);
                     ^
   
   ../../src/node_buffer.cc:1299:19: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
       String::Value value(env->isolate(), input);
                     ^
   
   ../../src/node_buffer.cc:1359:19: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
       String::Value value(env->isolate(), input);
                     ^
   
   [11/113] CXX obj/src/libnode.inspector_js_api.o
   ../../src/inspector_js_api.cc:249:17: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
     String::Value task_name_value(args.GetIsolate(), task_name);
                   ^
   
   [143/272] CXX obj/src/libnode.string_bytes.o
   ../../src/string_bytes.cc:325:23: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
           String::Value value(isolate, str);
                         ^
   
   ../../src/string_bytes.cc:381:23: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
           String::Value value(isolate, str);
                         ^
   
   ../../src/string_bytes.cc:403:23: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
           String::Value value(isolate, str);
                         ^
   
   ../../src/string_bytes.cc:497:21: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
         String::Value value(isolate, str);
                       ^
   
   ../../src/string_bytes.cc:503:21: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
         String::Value value(isolate, str);
                       ^
   
   [159/272] CXX obj/src/libnode.inspector_js_api.o
   ../../src/inspector_js_api.cc:249:17: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you cannot. [-Wdeprecated-declarations]
     String::Value task_name_value(args.GetIsolate(), task_name);
                   ^
   
2. avivkeller

   added

   v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.

   deprecationsIssues and PRs related to deprecations.Issues and PRs related to deprecations.

   on Aug 17, 2024
3. nodejs-github-bot

   closed this as completedin #55458on Oct 29, 2024
4. nodejs-github-bot

   closed this as completedin 45c6a9eon Oct 29, 2024
5. CGQAQ

   added a commit that references this issue on Oct 29, 2024

   src: migrate `String::Value` to `String::ValueView`

   ...

   This issue will close once commit 45c6a9e is merged into the 'main' branch.

   45c6a9e
6. RafaelGSS

   added a commit that references this issue on Nov 1, 2024

   src: migrate `String::Value` to `String::ValueView`

   ...

   This issue will close once commit efa142c is merged into the 'main' branch.

   efa142c