Repository navigation
Ed25519/Ed448 does not throw when used with invalid digest in crypto.createSign #52097
Description
What is the problem this feature will solve?
The following example:
const crypto = require('crypto');
const key = crypto.generateKeyPairSync("ed25519");
var signature = crypto.sign(null, "hello", key.privateKey);
console.log("crypto.sign:", signature.toString('hex'));
var signer = crypto.createSign('SHA256');
signer.update('hello');
var signature = signer.sign(key.privateKey);
console.log("signer.sign:", signature.toString('hex'));will output the following:
crypto.sign: d58fdfa69f9d0bf4fd5358a6ed22031af3585ce9812b2bde5a5045a4e3cefd719a5af771af85e5a0c406fd48852574debe4deb32845785b761c59978b21fa903
signer.sign: 00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000When Signer is used for Ed25519 signing, Signer does not report any errors, but returns an all-zero Buffer as the signature result.
This can be confusing for programmers who think they have signed successfully, but in fact the returned signature is not available.
What is the feature you are proposing to solve the problem?
I think in this case Signer.sign should throw an error so that the programmer can deal with the problem early on.
What alternatives have you considered?
No response
Activity
panva commentedon Mar 17, 2024
This seems like a bug. Ed25519 and Ed448 should only be available via the oneshot apis in the first place.
xicilion commentedon Mar 18, 2024
Yes, there is indeed an error here, so an error should be thrown here instead of returning a zero-filled Buffer.
[-]It is recommended to throw an error when passing Ed25519 private key to Signer.[/-][+]Ed25519/Ed448 does not throw when used with invalid digest in crypto.createSign[/+]panva commentedon Mar 19, 2024
cc @nodejs/crypto
medic-code commentedon Mar 22, 2024
I would like to work on this if nobody else is.
crypto: reject Ed25519/Ed448 in Sign/Verify prototypes
crypto: reject Ed25519/Ed448 in Sign/Verify prototypes
crypto: reject Ed25519/Ed448 in Sign/Verify prototypes
crypto: reject Ed25519/Ed448 in Sign/Verify prototypes