You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I guess node-test-pull-request does not rebase against current master the way node-accept-pull-request does/did. I wonder if it ought to? /cc @nodejs/build @nodejs/testing
Closing this for now. Feel free to re-open if you think that's not right. But I don't believe the test is currently flaky on master.
Activity
Trott commentedon Feb 12, 2016
And another:
santigimeno commentedon Feb 13, 2016
Can anyone copy the test output? Thanks
r-52 commentedon Feb 13, 2016
@santigimeno I've excluded some
# X 200output to keep it short...test: mark test-http-agent flaky
Trott commentedon Feb 16, 2016
Another one:
test: mark test-http-agent flaky
test: mark test-http-agent flaky
test: mark test-http-agent flaky
Trott commentedon Feb 20, 2016
Another one:
Trott commentedon Feb 20, 2016
Stress test confirming failure on current master branch. (Mostly useful to show that it's flaky in stress tests. It's possible for a test to be flaky in CI but not in stress test.) https://ci.nodejs.org/job/node-stress-single-test/510/nodes=pi2-raspbian-wheezy/console
17 remaining items
Trott commentedon Feb 25, 2016
@mhdawson Confirmed that the branch being tested (https://github.com/stefanmb/node/commits/test-runner-fix) does not have the fix committed.
I guess node-test-pull-request does not rebase against current master the way node-accept-pull-request does/did. I wonder if it ought to? /cc @nodejs/build @nodejs/testing
Closing this for now. Feel free to re-open if you think that's not right. But I don't believe the test is currently flaky on master.
orangemocha commentedon Feb 25, 2016
It's supposed to, but it's a parameter and rebasing can be skipped. Let me know if you think it's not working as expected.
test: mitigate flaky test-http-agent
test: mark test-http-agent flaky
test: mitigate flaky test-http-agent
test: mitigate flaky test-http-agent
test: mitigate flaky test-https-agent
test: mitigate flaky test-https-agent
test: mitigate flaky test-https-agent
test: mitigate flaky test-https-agent
test: mitigate flaky test-https-agent