Repository navigation
postject sometimes cannot inject the SEA blob on Windows, resulting in flaky test #49630
Description
Refs: nodejs/reliability#663
And from a recent run that includes #49543 https://ci.nodejs.org/job/node-test-binary-windows-js-suites/23086/RUN_SUBSET=1,nodes=win2016-COMPILED_BY-vs2022-x86/console
14:07:48 �[36mStart injection of NODE_SEA_BLOB in C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.944\sea.exe...�[0m
14:07:48 �[31mError: Aborted(). Build with -sASSERTIONS for more info.�[0m
It looks like sometimes postject is unable to inject the blob? cc @RaisinTen
Activity
RaisinTen commentedon Sep 13, 2023
My Windows setup is not working right now. I can try to take a look in a couple of days.
joyeecheung commentedon Sep 18, 2023
It can also fail on Linux during loading, I suspect we need https://chromium-review.googlesource.com/c/v8/v8/+/4608330 to fix it, but that seems separate from the postject failure on Windows
joyeecheung commentedon Sep 25, 2023
Not sure why but this has stopped showing up in the CI..
richardlau commentedon Sep 29, 2023
Showed up in https://ci.nodejs.org/job/node-test-binary-windows-js-suites/23422/RUN_SUBSET=2,nodes=win2016-COMPILED_BY-vs2022-x86/
anonrig commentedon Oct 17, 2023
Showed up in https://ci.nodejs.org/job/node-test-binary-windows-js-suites/23881/
test: set sea snapshot tests as flaky
test: set sea snapshot tests as flaky
test: set sea snapshot tests as flaky
joyeecheung commentedon Nov 15, 2023
I am not sure why they are still showing up in reliability reports after #50223 but they are still flaky, and it appears that other SEA tests are flaky too probably due to the same reason nodejs/reliability#718 - SIGSEGV when executing the SEA, on RHEL, Windows and macOS. Maybe we should open a separate issue because the original issue happened during injection.
joyeecheung commentedon Feb 26, 2024
This also shows up for the asset test on Windows: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/26136/RUN_SUBSET=2,nodes=win2016-COMPILED_BY-vs2022-x86/console. I suspect that postject may have trouble injecting slightly bigger files under certain circumstances.
We could probably investigate building it with ASSERTIONS.
[-]test-single-executable-application-snapshot(-and-code-cache) is flaky[/-][+]postject sometimes cannot inject the SEA blob on Windows, resulting in flaky test[/+]joyeecheung commentedon Feb 26, 2024
I wonder if we just skip the test if any of the following failed:
In those cases, the failures are unlikely to be fixable by Node.js core anyway...though it might still be useful to know when it fails 100% which indicates that something is wrong with our workflow. Not sure how we can know that in single tests though.
test: skip SEA tests when SEA generation fails
test: skip SEA tests when SEA generation fails
joyeecheung commentedon Apr 18, 2025
This seems to have disappeared. Closing.