Repository navigation
deps: bundle full sources of undici and not just precompiled blob #42199
Description
What is the problem this feature will solve?
Current Nodejs is bundling undici but instead of the sources, we only have a pre-compiled blob.
What is the feature you are proposing to solve the problem?
Bundle the entire indici snapshot in nodejs versions. In sources maybe this could be done with git submodules but also just an outright copy of specific checkout.
What alternatives have you considered?
No response
Activity
targos commentedon Mar 3, 2022
What would be the advantage(s) of doing it?
AdamMajer commentedon Mar 3, 2022
For distributions, we always like to have the sources available so we can build from them. For example, in the future maybe a fix needs to be applied and just upgrading the entire package to the latest version may be no longer compatible.
I guess for Debian, the bundled .js + wasm is not even distributable since it's not preferred source format for modifications.
[-]deps: bundle full sources of indici and not just precompiled blob[/-][+]deps: bundle full sources of undici and not just precompiled blob[/+]mhdawson commentedon Mar 3, 2022
can yo clarify what you mean by that?
AdamMajer commentedon Mar 4, 2022
benjamingr commentedon Mar 5, 2022
I think this is a reasonable ask to make floating patches easier but I'm hesitant to sacrifice the developer experience somewhat for it.
For what it's worth and just to be clear undici is open source too and you can change stuff in the "wasm bits" (llhttp, another dep that is also open source), build it and then tell Node.js to use it by updating undici in the deps folder.
Would a process that makes that change easier help or is avoiding having any blobs the important bit?
Note (funnily) Node.js already builds llhttp since it also uses it internally, I wonder how much work it would be to just get that to produce the wasm for undici.
@dnlup worked on the wasm build if I am reading the llhttp repo correctly, maybe he can weigh in?
deps: update undici to 4.15.1
targos commentedon Mar 7, 2022
I opened #42246 which includes a copy of the undici sources in deps/undici/src.
mhdawson commentedon Mar 7, 2022
@AdamMajer does #42246 address your concern?
AdamMajer commentedon Mar 9, 2022
@mhdawson yes, thank you.
mhdawson commentedon Mar 9, 2022
@AdamMajer thanks, great to hear wanted to be sure there were not other concerns.
deps: update undici to 4.15.1
deps: update undici to 4.15.1
deps: update undici to 4.15.1
deps: update undici to 4.15.1