Skip to content

operator || #40699

Closed
Closed
operator ||#40699
Labels
fsIssues and PRs related to file-system APIs and the fs module.

Description

@essential-existence
essential-existence
opened on Nov 2, 2021

node/lib/internal/fs/promises.js

Line 524 in d68dd62

position = bufferOrOptions.position || null;

If the value is "0", it is converted to "null", which causes the low-level read position of the file to be taken into account. I suggest:
position = bufferOrOptions.position ?? null;.

Operator || - this evil!

Activity

  1. tniessen
    added
    fsIssues and PRs related to file-system APIs and the fs module.
    on Nov 2, 2021
  2. Trott
    added
    invalidIssues and PRs that are invalid.
    on Nov 2, 2021
  3. Trott
    closed this as completedon Nov 2, 2021
  4. Trott
    reopened this on Nov 2, 2021
  5. Trott
    removed
    invalidIssues and PRs that are invalid.
    on Nov 2, 2021

  6. mihilmy commented on Nov 3, 2021

    @mihilmy
    mihilmy
    on Nov 3, 2021
    Contributor

    Duplicate of #40715
    I have some more details with repros in #40715

  7. VoltrexKeyva
    linked a pull request that will close this issueUse nullish coalescing to respect zero positional reads #40716on Nov 3, 2021

  8. essential-existence commented on Nov 6, 2021

    @essential-existence
    essential-existence
    on Nov 6, 2021
    Author

    Duplicate of #40715 I have some more details with repros in #40715

    I am glad that you soon noticed this error too.

  9. Trott
    closed this as completedin 2037ee8on Nov 12, 2021
  10. targos
    added a commit that references this issue on Nov 21, 2021

    fs: nullish coalescing to respect zero positional reads

    a5a1691
  11. richardlau
    added a commit that references this issue on Jan 25, 2022

    fs: nullish coalescing to respect zero positional reads

    fc328f1
  12. danielleadams
    added 2 commits that reference this issue on Jan 30, 2022

    fs: nullish coalescing to respect zero positional reads

    7e221ae

    fs: nullish coalescing to respect zero positional reads

    0377edc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fsIssues and PRs related to file-system APIs and the fs module.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions