Repository navigation
Memory Leak on v16.0.0-pre #38958
Description
The pss/rss of the heap in /proc/pid/smaps will increase about 52k every time when I execute following code:
Please help to figure it out.
Thanks.
function newDate(){
sysTime = new Date().toLocaleTimeString('en-US')
}
setInterval(newDate, 1000);
And when I remove the parameter "en-US" of toLocaleTimeString, the program doesn't leak.
Activity
bl-ue commentedon Jun 7, 2021
Ayase-252 commentedon Jun 7, 2021
Does the issue happened on v16.3.0 or master(v17.0.0-pre)?
luhuaipei commentedon Jun 8, 2021
@Ayase-252 Hi
Here is the test result:
tag v14.17.0 NG
tag v15.14.0 NG
v16. 0. 0 OK
v16. 3. 0 OK
Ayase-252 commentedon Jun 8, 2021
@luhuaipei
So... it looks fixed in v16. I suspect that #38178 fixed the issue since it is the only ICU-related change in v16.0.0 release and it will be release in v14.17.1 soon. You could try at that time.
luhuaipei commentedon Jun 9, 2021
@Ayase-252 Thanks. I cherry-picked the patch to my local, the issue still exists. Do you have other suggestions?
Ayase-252 commentedon Jun 9, 2021
@luhuaipei Sorry, I don't have a clue now.
cc @nodejs/i18n-api
luhuaipei commentedon Jun 9, 2021
It seems the issue resides in v8. I use the d8 tool in V8(version 8.8.6) can reproduce this issue.
In d8 console, every time I execute
The Rss section will increase by 52-56Kb.
targos commentedon Jun 9, 2021
@nodejs/v8
luhuaipei commentedon Jun 9, 2021
v8/v8@4b139f7
This patch indroduced the fix in v8 version(8.9.1)
gengjiawen commentedon Jun 9, 2021
@gsathya Can you take a look ?
gengjiawen commentedon Jun 13, 2021
cc @verwaest Is this you can help ?
nikikalwar commentedon Jun 17, 2021
Hi All,
I took a look and it really exists, interested in working on it.
`let my_process=process;
function getTime(){
console.log(new Date().toLocaleTimeString('en-US'));
console.log(my_process.memoryUsage())
}
setInterval(getTime,2000)
`
bl-ue commentedon Jun 17, 2021
@nikikalwar the best way to fix it would be to take a look at the commit v8/v8@4b139f7 and figure out just what in that commit started making it so slow.
targos commentedon May 3, 2023
Closing as v14.x is EoL.