Skip to content

--enable-source-maps does not appear to show function names with webpack sourcemaps #35325

Closed
Closed
--enable-source-maps does not appear to show function names with webpack sourcemaps#35325
Assignees
bcoe
Labels
source mapsIssues and PRs related to source map support.

Description

@michael-wolfenden
michael-wolfenden
opened on Sep 24, 2020
  • Version: v12.13.0
  • Platform: Windows 10 64-bit
  • Subsystem: sourcemaps

What steps will reproduce the bug?

Here is a complete, minimal reproduction
https://github.com/michael-wolfenden/node-sourcemap-repro

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior?

I would expect to see the real function names in the output.

Using the source-map-support package, the stack trace looks like:

> node ./dist/main.js

D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:16
  throw new Error('Roh Ruh')
        ^
Error: Roh Ruh
    at functionD (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:16:9)
    at functionC (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:12:3)
    at functionB (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:8:3)
    at Object.call (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:4:3)
    at __webpack_require__ (D:\github\node-sourcemap-repro\dist\webpack:\webpack\bootstrap:19:22)
    at D:\github\node-sourcemap-repro\dist\webpack:\webpack\bootstrap:83:10
    at Object.<anonymous> (D:\github\node-sourcemap-repro\dist\main.js:1:911)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at Module.load (internal/modules/cjs/loader.js:812:32)

What do you see instead?

Using the --enable-source-maps flag, the stack trace looks like:

> node --enable-source-maps ./dist/main.js

Error: Roh Ruh
    at o (D:\github\node-sourcemap-repro\dist\main.js:1:970)
        -> D:\github\node-sourcemap-repro\dist\webpack:\index.js:14:9
    at n (D:\github\node-sourcemap-repro\dist\main.js:1:952)
        -> D:\github\node-sourcemap-repro\dist\webpack:\index.js:10:3
    at r (D:\github\node-sourcemap-repro\dist\main.js:1:940)
        -> D:\github\node-sourcemap-repro\dist\webpack:\index.js:6:3
    at Object.<anonymous> (D:\github\node-sourcemap-repro\dist\main.js:1:992)
        -> D:\github\node-sourcemap-repro\dist\webpack:\index.js:2:3
    at r (D:\github\node-sourcemap-repro\dist\main.js:1:110)
        -> D:\github\node-sourcemap-repro\dist\webpack:\webpack\bootstrap:19:22
    at D:\github\node-sourcemap-repro\dist\main.js:1:902
        -> D:\github\node-sourcemap-repro\dist\webpack:\webpack\bootstrap:83:10
    at Object.<anonymous> (D:\github\node-sourcemap-repro\dist\main.js:1:911)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)        
    at Module.load (internal/modules/cjs/loader.js:812:32)

Activity

  1. watilde
    added
    source mapsIssues and PRs related to source map support.
    on Sep 26, 2020
  2. bcoe
    self-assigned this
    on Oct 29, 2020

  3. bcoe commented on Oct 30, 2020

    @bcoe
    bcoe
    on Oct 30, 2020
    Contributor

    @michael-wolfenden I'm wondering if you have any recommendations on how we should display the original function name?

    The approach we've taken is to provide information about bot the call site with the error and the original call site, I'm wondering how we'd represent an alternate function name.

  4. bcoe commented on Oct 31, 2020

    @bcoe
    bcoe
    on Oct 31, 2020
    Contributor

    @michael-wolfenden what do you think of this?

    Error: oh no!
    at o (/Users/bencoe/oss/node-1/test/fixtures/source-map/webpack.js:1:970)
        -> [functionA] webpack:///./webpack.js:14:9
    at n (/Users/bencoe/oss/node-1/test/fixtures/source-map/webpack.js:1:952)
        -> [functionB] webpack:///./webpack.js:10:3

  5. michael-wolfenden commented on Oct 31, 2020

    @michael-wolfenden
    michael-wolfenden
    on Oct 31, 2020
    Author

    I would expect the output to look something like the output that source-map-support generates

    > node ./dist/main.js

D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:16
  throw new Error('Roh Ruh')
        ^
Error: Roh Ruh
    at functionD (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:16:9)
    at functionC (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:12:3)
    at functionB (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:8:3)
    at Object.call (D:\github\node-sourcemap-repro\dist\webpack:\index-source-map-support.js:4:3)
    at __webpack_require__ (D:\github\node-sourcemap-repro\dist\webpack:\webpack\bootstrap:19:22)
    at D:\github\node-sourcemap-repro\dist\webpack:\webpack\bootstrap:83:10
    at Object.<anonymous> (D:\github\node-sourcemap-repro\dist\main.js:1:911)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at Module.load (internal/modules/cjs/loader.js:812:32)

  6. bcoe commented on Oct 31, 2020

    @bcoe
    bcoe
    on Oct 31, 2020
    Contributor

    @michael-wolfenden we've opted to include both the call site where the error happened, and the original call site in our implementation of applying source maps to stack traces in Node.js.

    This is useful because sometimes you do want to look at the actual location where the error was thrown, i.e.,

    at o (/Users/bencoe/oss/node-1/test/fixtures/source-map/webpack.js:1:970)

    ☝️ especially when using a minifier there can be bugs that only crop up in the minified code, e.g., a collision on symbol names.

    I'd like to figure out a way to provide the original function name for you, without hiding the actual function name that executed.

  7. bcoe
    added a commit that references this issue on Oct 31, 2020

    errors: do not call resolve on URLs with schemes

    44f20fc

  8. michael-wolfenden commented on Oct 31, 2020

    @michael-wolfenden
    michael-wolfenden
    on Oct 31, 2020
    Author

    Ah gotcha ... In that case, your suggestion looks good 👍

  9. bcoe
    added a commit that references this issue on Nov 3, 2020

    errors: do not call resolve on URLs with schemes

    26fcdb6
  10. bcoe
    added a commit that references this issue on Nov 27, 2020

    errors: display original symbol name

    56d7975
  11. bcoe
    closed this as completedin 09fd8f1on Dec 1, 2020
  12. danielleadams
    added a commit that references this issue on Dec 7, 2020

    errors: display original symbol name

    c14512b
  13. targos
    added 2 commits that reference this issue on Apr 24, 2021

    errors: do not call resolve on URLs with schemes

    753d783

    errors: do not call resolve on URLs with schemes

    b01c496
  14. targos
    added a commit that references this issue on May 16, 2021

    errors: display original symbol name

    47b822f
  15. targos
    added a commit that references this issue on Jun 11, 2021

    errors: display original symbol name

    ee44447
  16. MayaLekova
    added a commit that references this issue on May 22, 2026

    errors: display original symbol name

    09fd8f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

source mapsIssues and PRs related to source map support.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions