Repository navigation
s390 fails to build #28866
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.s390xIssues and PRs related to the s390x architecture.Issues and PRs related to the s390x architecture.
Description
- Version: Node12
- Platform: s390 (as opposed to s390x) on SLES 12
- Subsystem: v8
[ 312s] g++-7 -o /home/abuild/rpmbuild/BUILD/node-v12.7.0/out/Release/obj.target/v8_compiler
/deps/v8/src/compiler/backend/instruction-selector.o ../deps/v8/src/compiler/backend/instructio
n-selector.cc '-DNODE_OPENSSL_CERT_STORE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=6
4' '-DOPENSSL_THREADS' '-DV8_TARGET_ARCH_S390' '-DV8_EMBEDDER_STRING="-node.16"' '-DENABLE_DISA
SSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DENABLE_MINOR_MC' '-DV8_INTL_SUPPORT' '-DV8_U
SE_SNAPSHOT' '-DV8_CONCURRENT_MARKING' '-DV8_EMBEDDED_BUILTINS' '-DV8_USE_SIPHASH' '-DDISABLE_U
NTRUSTED_CODE_MITIGATIONS' '-DV8_WIN64_UNWINDING_INFO' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYL
OAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -
I../deps/v8 -I../deps/v8/include -I/home/abuild/rpmbuild/BUILD/node-v12.7.0/out/Release/obj/gen
/generate-bytecode-output-root -I/home/abuild/rpmbuild/BUILD/node-v12.7.0/out/Release/obj/gen/t
orque-output-root -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -pthread -
Wno-unused-parameter -m31 -march=z196 -Wno-return-type -march=z196 -fno-strict-aliasing -m31 -O
3 -fno-omit-frame-pointer -flto=4 -fuse-linker-plugin -ffat-lto-objects -fdata-sections -ffunct
ion-sections -O3 -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /home/abuild/rpmbuild/BUILD/no
de-v12.7.0/out/Release/.deps//home/abuild/rpmbuild/BUILD/node-v12.7.0/out/Release/obj.target/v8
_compiler/deps/v8/src/compiler/backend/instruction-selector.o.d.raw -fmessage-length=0 -grecor
d-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-u
nwind-tables -fstack-clash-protection -Wno-class-memaccess -c
[ 312s] In file included from ../deps/v8/src/reloc-info.h:10:0,
[ 312s] from ../deps/v8/src/compiler/common-operator.h:13,
[ 312s] from ../deps/v8/src/compiler/backend/instruction.h:15,
[ 312s] from ../deps/v8/src/compiler/backend/instruction-scheduler.h:8,
[ 312s] from ../deps/v8/src/compiler/backend/instruction-selector.h:10,
[ 312s] from ../deps/v8/src/compiler/backend/instruction-selector.cc:5:
[ 312s] ../deps/v8/src/objects/code.h:423:2: error: #error Unknown architecture.
[ 312s] #error Unknown architecture.
[ 312s] ^~~~~
It seems that v8 is failing to build in Node 12.x since PR: #25852 . Does anyone know if s390 (31-bit) is no longer a supported target for v8?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.s390xIssues and PRs related to the s390x architecture.Issues and PRs related to the s390x architecture.
Activity
richardlau commentedon Jul 26, 2019
cc @nodejs/platform-s390
bnoordhuis commentedon Jul 28, 2019
That's right, support for s390 (but not s390x) was dropped at the start of the year. ppc32 as well.
build: remove support for s390 (but not s390x)
build: remove support for s390 (but not s390x)
Trott commentedon Jul 30, 2019
Fixed in fd9e0f7.
build: remove support for s390 (but not s390x)