Repository navigation
fs.mkdir/mkdirSync hang with {recursive: true} if name is invalid #28599
Description
- Version: 10.16.0, 11.14.0, 12.6.0
- Platform: Windows 10
- Subsystem: fs
If the name of the dir to be created is invalid, fs.mkdir never calls back and fs.mkdirSync blocks:
const fs = require('fs')
console.log("1")
fs.mkdir('invalid1:', {recursive: true}, (err) => {
console.log("is not called")
if (err) throw err
})
console.log("2")
fs.mkdirSync('invalid2:', {recursive: true})
console.log("is not reached")
BTW, the error message that is reported with {recursive: false} appears a bit strange:
Error: ENOENT: no such file or directory, mkdir 'invalid2:'
Wouldn't it be more convenient to use EPERM, EACCES or ENOTDIR?
Activity
Hakerh400 commentedon Jul 8, 2019
Colons on NTFS files systems on Windows denote file streams (source).
jeffrson commentedon Jul 8, 2019
The error is the same for "invalid>", "invalid<" oder "invalid|".
silverwind commentedon Jul 9, 2019
Those are all invalid characters on NTFS, see here.
Not sure if Node.js should do validation for those (and take a performance hit on every platform). There are modules like this which you can use to validate yourself.
The hang itself should probably be investigated, thought.
jeffrson commentedon Jul 10, 2019
Yes - I know this module. However, it is not cross plattform as far as I can tell - ':', '<', '>','|' may be valid on Linux (although not necessarily recommended, I guess). Yes, of course I could distinguish platforms. But I could as well rely on "fs.mkdir" to fail, if something is wrong.
The point is, Node should, if it fails to create the directory for whatever reason, give a reasonable error and, of course, not hang - with { recursive: true } or not.
win, fs: mkdir return UV_EINVAL for invalid names
win, fs: mkdir return UV_EINVAL for invalid names
bzoz commentedon Jul 11, 2019
This is similar to #27198, which was fixed by #27207.
For invalid filenames,
uv_fs_mkdirreturnsUV_ENOENT, which confuses thefs.mkdirfunction. It constantly creates the parent directory then tries to create the invalid folder.Made a libuv PR that makes it return
UV_EINVALfor invalid filenames. This fixes this issue.win, fs: mkdir return UV_EINVAL for invalid names
deps: upgrade to libuv 1.31.0
deps: upgrade to libuv 1.31.0
win, fs: mkdir return UV_EINVAL for invalid names
win, fs: mkdir return UV_EINVAL for invalid names
fix(test): 审计用例在 Linux 上活锁，CI 从来不是变红而是卡死
fix(fs): 递归 mkdir 会在 procfs 上活锁，换成有界实现