Repository navigation
Investigate flaky test-crypto-timing-safe-equal-benchmarks #25984
Description
https://ci.nodejs.org/job/node-test-commit-custom-suites/864/default/console
test-rackspace-ubuntu1604-x64-1
00:05:42 not ok 62 pummel/test-crypto-timing-safe-equal-benchmarks
00:05:42 ---
00:05:42 duration_ms: 27.177
00:05:42 severity: fail
00:05:42 exitcode: 1
00:05:42 stack: |-
00:05:42 assert.js:351
00:05:42 throw err;
00:05:42 ^
00:05:42
00:05:42 AssertionError [ERR_ASSERTION]: timingSafeEqual should not leak information from its execution time (t=4.860941889108833)
00:05:42 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites/default/test/pummel/test-crypto-timing-safe-equal-benchmarks.js:106:1)
00:05:42 at Module._compile (internal/modules/cjs/loader.js:735:30)
00:05:42 at Object.Module._extensions..js (internal/modules/cjs/loader.js:746:10)
00:05:42 at Module.load (internal/modules/cjs/loader.js:627:32)
00:05:42 at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
00:05:42 at Function.Module._load (internal/modules/cjs/loader.js:562:3)
00:05:42 at Function.Module.runMain (internal/modules/cjs/loader.js:798:12)
00:05:42 at internal/main/run_main_module.js:27:11
00:05:42 ...
Activity
Trott commentedon Feb 7, 2019
@nodejs/crypto
Trott commentedon Feb 7, 2019
@not-an-aardvark
Trott commentedon Feb 20, 2019
https://ci.nodejs.org/job/node-test-commit-custom-suites/880/default/console
test-rackspace-ubuntu1604-x64-1
Trott commentedon Feb 20, 2019
Last successful run took 52 seconds. If there's significant randomness involved (which seems possible given that it's crypto), then a two minute timeout might be an expected result from time to time. But I don't actually know.
Trott commentedon Feb 20, 2019
Meh, maybe not. Successful results are pretty consistent in duration. 52 seconds, 53 seconds, 52 seconds....
test: add (temporary) logging for unreliable test
Trott commentedon Feb 21, 2019
Cause is #26229.
test: improve performance of test-crypto-timing-safe-equal-benchmarks
test: improve performance of test-crypto-timing-safe-equal-benchmarks