You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
parallel/test-benchmark-misc failure on v8.x-staging #19394
need to backport this #16251 to solve the issue. I saw the backport-requested-v8.x label in that PR. basically, the ubuntu1604_sharedlibs_withoutintl_x64 will keep hitting this issue until that PR is backported.
@MylesBorins#16251 modifies benchmark/misc/punycode.js and that fixes the failure of parallel/test-benchmark-misc.
at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/benchmark/misc/punycode.js:4:21)
Activity
yhwang commentedon Mar 16, 2018
need to backport this #16251 to solve the issue. I saw the
backport-requested-v8.xlabel in that PR. basically, theubuntu1604_sharedlibs_withoutintl_x64will keep hitting this issue until that PR is backported.MylesBorins commentedon Mar 20, 2018
@yhwang that PR seems to touch code that was only added in 9.x. Not 100% it is the exact same problem
MylesBorins commentedon Mar 20, 2018
ping @srl295
yhwang commentedon Mar 20, 2018
@MylesBorins #16251 modifies
benchmark/misc/punycode.jsand that fixes the failure ofparallel/test-benchmark-misc.apapirovski commentedon Jun 1, 2018
Fixed in #20478
srl295 commentedon Jun 1, 2018
without intl means the icu module won't be available, so it is the same issue
srl295 commentedon Jun 1, 2018
looks like it was fixed by a backport after all, anyway I did not see this at all