Repository navigation
errors: similar error codes [VALUE_OUT_OF_RANGE] and [OUT_OF_RANGE] #17603
Description
Now there are two similar error codes in lib:
Should we reduce them into one?
IMHO, the error message of ERR_VALUE_OUT_OF_RANGE is more detailed instead of a simple string('The "%s" argument is out of range') of ERR_OUT_OF_RANGE, so we might be able to migrate the ERR_OUT_OF_RANGE into ERR_VALUE_OUT_OF_RANGE.
- Version: nodejs/node:master
- Platform: all
- Subsystem: errors
Activity
Fishrock123 commentedon Dec 11, 2017
cc @jasnell
BridgeAR commentedon Dec 11, 2017
I am a fan of combining such similar error types. So +1 from me. I would say, just go ahead and open a PR.
benjamingr commentedon Dec 11, 2017
+1 for me as well, semver-major though.
lib: combine similar error codes