Skip to content

Why do we include both *-inl.h and *.h in the same .cc file? #16519

Closed
Closed
Why do we include both *-inl.h and *.h in the same .cc file?#16519
Labels
c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.questionIssues asking questions about Node.js.

Description

@joyeecheung
joyeecheung
opened on Oct 26, 2017
  • Version: master
  • Subsystem: src

Just noticed this when doing #16122, clang-format has a different idea of alphabetical orders and put -inl.h includes before .h includes. Is there a reason that we include them both? Usually including -inl.h is enough because they should include .h as well, and they should be self-contained.

Activity

  1. joyeecheung
    added
    lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.
    questionIssues asking questions about Node.js.
    c++Issues and PRs that require attention from people who are familiar with C++.
    on Oct 26, 2017

  2. joyeecheung commented on Oct 26, 2017

    @joyeecheung
    joyeecheung
    on Oct 26, 2017
    MemberAuthor

    Also if there is a reason for that I think it's worth adding that to the C++ style guide, AFAICT this is different from how V8 includes stuff as well.

  3. bnoordhuis commented on Oct 26, 2017

    @bnoordhuis
    bnoordhuis
    on Oct 26, 2017
    Member

    No real reason. I think I introduced it in the node.js code base and I probably copied it from the V8 code base.

  4. joyeecheung
    closed this as completedin cdb263don Oct 30, 2017
  5. Qard
    added 2 commits that reference this issue on Nov 2, 2017

    src: do not include x.h if x-inl.h is included

    b99b330

    src: do not include x.h if x-inl.h is included

    35d9c11
  6. joyeecheung
    added a commit that references this issue on Nov 2, 2017

    src: do not include x.h if x-inl.h is included

    f6a52a2
  7. cjihrig
    added a commit that references this issue on Nov 6, 2017

    src: do not include x.h if x-inl.h is included

    97fd6df
  8. gibfahn
    added a commit that references this issue on Nov 14, 2017

    src: do not include x.h if x-inl.h is included

    255fffb
  9. MylesBorins
    added 3 commits that reference this issue on Nov 16, 2017

    src: do not include x.h if x-inl.h is included

    f20bf69

    src: do not include x.h if x-inl.h is included

    9b736f9

    src: do not include x.h if x-inl.h is included

    b00ced5
  10. addaleax
    added a commit that references this issue on Dec 7, 2017

    src: do not include x.h if x-inl.h is included

    dd9a031
  11. sjarmak
    added a commit that references this issue on Jul 27, 2026

    src: do not include x.h if x-inl.h is included

    cdb263d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.questionIssues asking questions about Node.js.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions