Skip to content

Investigate flaky test/async-hooks/test-callback-error #15985

Closed
Closed
Investigate flaky test/async-hooks/test-callback-error#15985
Labels
async_hooksIssues and PRs related to the async hooks subsystem.flaky-testIssues and PRs involving tests that fail intermittently in CI.macosIssues and PRs related to the macOS platform.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@efreiberg
efreiberg
opened on Oct 6, 2017

Running test/async-hooks/test-callback-error.js test on the master branch(no local changes) reports failures on async hooks tests.

  • Version: v9.0.0-pre
  • Platform: Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64
  • Subsystem: async_hooks
$ ./node ./test/async-hooks/test-callback-error.js 
start case 1
end case 1: 85.844ms
start case 2
end case 2: 86.863ms
start case 3
end case 3: 4.478ms
Error: test_callback_abort
    at ActivityCollector.initHooks.oninit.common.mustCall (/Users/efreiberg/Documents/node_demo_2/node/test/async-hooks/test-callback-error.js:36:45)
    at ActivityCollector.oninit (/Users/efreiberg/Documents/node_demo_2/node/test/common/index.js:517:15)
    at ActivityCollector._init (/Users/efreiberg/Documents/node_demo_2/node/test/async-hooks/init-hooks.js:182:10)
    at emitInitNative (async_hooks.js:466:43)
    at Object.emitInitScript [as emitInit] (async_hooks.js:369:3)
    at Object.<anonymous> (/Users/efreiberg/Documents/node_demo_2/node/test/async-hooks/test-callback-error.js:38:17)
    at Module._compile (module.js:600:30)
    at Object.Module._extensions..js (module.js:611:10)
    at Module.load (module.js:521:32)
    at tryModuleLoad (module.js:484:12)
 1: node::Abort() [/Users/efreiberg/Documents/node_demo_2/node/out/Release/node]
 2: node::Chdir(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/efreiberg/Documents/node_demo_2/node/out/Release/node]
 3: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/Users/efreiberg/Documents/node_demo_2/node/out/Release/node]
 4: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/efreiberg/Documents/node_demo_2/node/out/Release/node]
 5: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/efreiberg/Documents/node_demo_2/node/out/Release/node]
 6: 0x35a344a0463d

$ sw_vers -productVersion 
10.11.5

Activity

  2. mscdex
    added
    async_hooksIssues and PRs related to the async hooks subsystem.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Oct 6, 2017

  3. cjihrig commented on Oct 7, 2017

    @cjihrig
    cjihrig
    on Oct 7, 2017
    Contributor

    Related to #15208?

  4. Trott commented on Oct 7, 2017

    @Trott
    Trott
    on Oct 7, 2017
    Member

    @Fishrock123 was investigating this at Code + Learn and might have some more information to add.

  5. MylesBorins commented on Nov 17, 2017

    @MylesBorins
    MylesBorins
    on Nov 17, 2017
    Contributor

    Just ran into this while running the 8.x test suite on my 10.10.5 machine

  6. gibfahn commented on Dec 13, 2017

    @gibfahn
    gibfahn
    on Dec 13, 2017
    Member

    I think I'm seeing the same thing on v8.x, on both macOS and Linux.

    === release test-callback-error ===                                            
Path: async-hooks/test-callback-error
start case 1
end case 1: 380.437ms
start case 2
end case 2: 648.707ms
start case 3
end case 3: 12.625ms
Error: test_callback_abort
    at ActivityCollector.initHooks.oninit.common.mustCall (/Users/gib/wrk/com/DANGER/node/test/async-hooks/test-callback-error.js:36:45)
    at ActivityCollector.oninit (/Users/gib/wrk/com/DANGER/node/test/common/index.js:533:15)
    at ActivityCollector._init (/Users/gib/wrk/com/DANGER/node/test/async-hooks/init-hooks.js:185:10)
    at emitInitNative (async_hooks.js:472:43)
    at Object.emitInitScript [as emitInit] (async_hooks.js:388:3)
    at Object.<anonymous> (/Users/gib/wrk/com/DANGER/node/test/async-hooks/test-callback-error.js:38:17)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
 1: node::Abort() [/Users/gib/wrk/com/DANGER/node/out/Release/node]
 2: node::Chdir(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/gib/wrk/com/DANGER/node/out/Release/node]
 3: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/Users/gib/wrk/com/DANGER/node/out/Release/node]
 4: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/gib/wrk/com/DANGER/node/out/Release/node]
 5: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/gib/wrk/com/DANGER/node/out/Release/node]
 6: 0x2ae711d8463d

    I'm also seeing cores dumped even when the test passes, which is odd. Testing with commit ab46b8e.

  7. Trott commented on Dec 14, 2017

    @Trott
    Trott
    on Dec 14, 2017
    Member

    @nodejs/async_hooks

  8. maclover7
    added
    macosIssues and PRs related to the macOS platform.
    on Dec 18, 2017

  9. kysnm commented on Dec 19, 2017

    @kysnm
    kysnm
    on Dec 19, 2017
    Contributor

    Getting the same error in
    v10.0.0-pre
    sw_vers -productVersion
    10.11.6

  10. kysnm commented on Dec 19, 2017

    @kysnm
    kysnm
    on Dec 19, 2017
    Contributor

    Error does not occur in the following environment
    v 10.0.0-pre
    sw_vers -productVersion
    10.12.6

  11. maclover7
    added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Dec 25, 2017

  12. shisama commented on May 25, 2018

    @shisama
    shisama
    on May 25, 2018
    Contributor

    Hasn't this problem been fixed yet?

    Error occurs in
    v 11.0.0-pre
    sw_vers -productVersion
    10.13.4

  13. Trott commented on May 25, 2018

    @Trott
    Trott
    on May 25, 2018
    Member

    Hasn't this problem been fixed yet?

    Unless someone knows the source of the problem, how can anyone know if it's fixed? The error happens unpredictably. I'm not convinced the macOS version is a significant factor. I'm running 10.11.6 and do not see this error occurring.

  14. shisama commented on May 26, 2018

    @shisama
    shisama
    on May 26, 2018
    Contributor

    Unless someone knows the source of the problem, how can anyone know if it's fixed?

    Sorry, I had a bad comment. I don't know the source of the problem.

    I'm not convinced the macOS version is a significant factor.

    The error occurs once yesterday. Today, the error doesn't occurs despite the same version.

  15. 6 remaining items

  16. joyeecheung
    changed the title [-]Async hook test 'test/async-hooks/test-callback-error' fails on OSX 10.11.5[/-] [+]Investigate flaky test/async-hooks/test-callback-error[/+] on Aug 14, 2018

  17. joyeecheung commented on Aug 14, 2018

    @joyeecheung
    joyeecheung
    on Aug 14, 2018
    Member

    Note that this also happens on fedora

  18. joyeecheung
    added 2 commits that reference this issue on Aug 15, 2018

    test: mark async-hooks/test-callback-error as flaky

    248296a

    test: mark async-hooks/test-callback-error as flaky

    59c8abf
  19. targos
    added a commit that references this issue on Aug 19, 2018

    test: mark async-hooks/test-callback-error as flaky

    32b5e00

  20. addaleax commented on Sep 2, 2018

    @addaleax
    addaleax
    on Sep 2, 2018
    Member

    I have a fix in #22655.

  21. addaleax
    added a commit that references this issue on Sep 2, 2018

    test: fix flaky async-hooks/test-callback-error

    efd776f
  22. targos
    added a commit that references this issue on Sep 3, 2018

    test: mark async-hooks/test-callback-error as flaky

    2ed22df
  23. addaleax
    closed this as completedin 67bfcb7on Sep 5, 2018
  24. sjarmak
    added a commit that references this issue on Jul 27, 2026

    test: fix flaky async-hooks/test-callback-error

    67bfcb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    async_hooksIssues and PRs related to the async hooks subsystem.flaky-testIssues and PRs involving tests that fail intermittently in CI.macosIssues and PRs related to the macOS platform.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions