You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure #1539 is worth discussing (yet?). I suppose we could talk about how much we'd be willing to re-style if we switched linters.. but I think the consensus will end up being "bare minimum" at most.
@trevnorris no real drastic changes except the double newline thing, which I think wasn't enforced by the old linter either.
Most of the changes are var redefinitions in the same scope and a few other inconistencies the old linter didn't catch. We'll try to keep the changes to a minimum.
Activity
rvagg commentedon Apr 29, 2015
sorry for the late notification @shigeki
shigeki commentedon Apr 29, 2015
@rvagg Never mind. I found this in the last minutes.
silverwind commentedon Apr 29, 2015
Added #1539 to the agenda (JS code style with two empty lines).Fishrock123 commentedon Apr 29, 2015
Adding #1559 unless it is otherwise cleared up beforehand
domenic commentedon Apr 29, 2015
Do we really need to elevate decisions of style to the TC?
silverwind commentedon Apr 29, 2015
I suppose it's not strictly necessary. The other option would be to leave the PR pending for a week or so and merge if no one objects directly.
Fishrock123 commentedon Apr 29, 2015
Not sure #1539 is worth discussing (yet?). I suppose we could talk about how much we'd be willing to re-style if we switched linters.. but I think the consensus will end up being "bare minimum" at most.
silverwind commentedon Apr 29, 2015
@Fishrock123 Agreed, let's give it a bit more time. There's a few more rules that will controversial because you can never satisfy everyone on style.
trevnorris commentedon Apr 29, 2015
@silverwind just to double check, will the style match to best possible what's already there or is it making drastic changes?
silverwind commentedon Apr 29, 2015
@trevnorris no real drastic changes except the double newline thing, which I think wasn't enforced by the old linter either.
Most of the changes are
varredefinitions in the same scope and a few other inconistencies the old linter didn't catch. We'll try to keep the changes to a minimum.Rossolson commentedon Apr 30, 2015
Seems like the timezone dates didn't get changed:
22-Mar-1513:0022-Mar-1522:0022-Mar-1523:0023-Mar-1506:00rvagg commentedon May 13, 2015
sorry for the late notification @shigeki