Remove async_hooks runInAsyncIdScope API

@trevnorris

Version: master (016d81c)
Platform: all
Subsystem: async_hooks

As I mentioned a few months ago I'm not comfortable exposing the low-level async_hooks JS API. In the documentation PR #12953 we agreed to keep the low-level JS API undocumented. Some time has now passed and I think we are in a better position to discuss this.

The low-level JS API is quite large, thus I would like to separate the discussion into:

A discussion about setInitTriggerId and triggerIdScope. (Remove async_hooks setTrigger API #14238)
A discussion about runInAsyncIdScope. (this)
A discussion about newUid, emitInit, emitBefore, emitAfter and emitDestroy (Remove async_hooks Sensitive/low-level Embedder API #15572).

Note: There is some overlap between emitInit and setInitTriggerId in terms of initTriggerId. Hopefully, that won't be an issue.

Background

runInAsyncIdScope(asyncId, cb) creates a new scope with the asyncId as
the executionAsyncId and with the current executionAsyncId as
the triggerAsyncId. It does so without invoking the before and after hooks.

runInAsyncIdScope was not part of the original async_hooks EP but
was included in the async_hooks PR.

runInAsyncIdScope is not used anywhere in node-core and as such, it purpose
is not well documented. @trevnorris mentions it only a single time:

This could also be used by something like a database module, where multiple queries should be treated as their own async operations, but the actual operation is combined into a single query internally. This is the reason for async_hooks.runInAsyncIdScope():

// A pooled resource on top of a native resource
class MyResource inherits async_hooks.AsyncResource {
  constructor() {
    super('MyResource');
  }
  query(val, cb) {
    // query() will pool the actual request then call each callback with
    // the specific data it requested.
    nativeResource.query(val, (er, data) => {
      async_hooks.runInAsyncIdScope(this.asyncId(), () => cb(er, data));
    });
  }
}

const mr = new MyResource();
mr.query(val, (er, data) => {
  // Now when init() fires for writeFile() it will have both the currentId and
  // triggerId of the JS instance.
  fs.writeFile(path, data.toString());
});

Although, later @trevnorris says it is a bad example.

Issues

The primary issue is that emitBefore and emitAfter are not used, thus
the before and after hooks are never invoked. This can be an issue if the user
depends on the executionAsyncId() to match the asyncId in the before hook.

For example, in trace I at some point used:

let stack = [];

createHook({
  before(asyncId) {
    stack.push(states.get(asyncId));
  },
  after(asyncId) {
    stack.pop();
  }
})

However, because of runInAsyncIdScope this is actually invalid code.

Solution

We remove runInAsyncIdScope
The user should use AsyncResource and emitBefore/emitAfter to change
executionAsyncId() and triggerAsyncId().

Note: We may want to just deprecate the API in node 8 and remove it in a future version.

For example, the DB resource example should be implemented as:

// A pooled resource on top of a native resource
class MyResource inherits async_hooks.AsyncResource {
  constructor() {
    super('MyResource');
  }
  query(val, cb) {
    // query() will pool the actual request then call each callback with
    // the specific data it requested.
    nativeResource.query(val, (er, data) => {
      this.emitBefore();
      cb(er, data);
      this.emitAfter();
    });
  }
}

/cc @nodejs/async_hooks

I'd like to voice an issue I encountered when trying to use AsyncResource. Because it is a ES6 class, it is impossible for me to create a class that extends both AsyncResource and, say, EventEmitter. Is there a way to resolve this issue?

@TimothyGu

@TimothyGu Short answer is that you can use newUid, emitInit, emitBefore, emitAfter and emitDestroy. I will address it in a future issue about emitInit and friends.

@AndreasMadsen

@AndreasMadsen Okay. I would still much prefer a more generic solution though, like so:

class MyClass extends EventEmitter {
  constructor() {
    super();
    AsyncResource.call(this, 'name');
  }

  method(cb) {
    this.on('event', () => {
      native((err, data) => {
        this.emitBefore();
        try {
          cb(err, data);
        } finally {
          this.emitAfter();
        }
      });
    });
  }
}
Object.defineProperties(
    MyClass.prototype,
    Object.getOwnPropertyDescriptors(AsyncResource.prototype));

I don't want to derail the original conversation of course, and I'd be happy to move this into a new issue.

runInAsyncIdScope() is a bad API. It's should actually be initTriggerIdScope() (i.e. it should dictate the triggerId passed to init(), nothing more). The pre-PR implementation did this, but I must have overlooked the functionality difference along the way. In short, this API shouldn't have existed in the first place.

So, setInitTriggerId() and runInAsyncIdScope() don't address the same problem. Let's remove this API completely, and continue discussion about the need for setInitTriggerId() in #14238.

EDIT: I tracked down the last commit left in my repo to show that it did at one point do as previously intended at trevnorris@4b16a58#diff-0bb01a51b135a5f68d93540808bac801R179

@TimothyGu

I don't want to derail the original conversation of course, and I'd be happy to move this into a new issue.

@TimothyGu Please do.

@TimothyGu

@TimothyGu Please add the link to the new issue here when it's created.

async_hooks: deprecate undocumented API

Navigation Menu

Repository navigation

Remove async_hooks runInAsyncIdScope API #14328

Background

Issues

Solution

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Remove async_hooks runInAsyncIdScope API #14328

Description

Background

Issues

Solution

Activity

TimothyGu commented on Jul 18, 2017

AndreasMadsen commented on Jul 18, 2017

TimothyGu commented on Jul 18, 2017

trevnorris commented on Jul 18, 2017

AndreasMadsen commented on Jul 18, 2017

trevnorris commented on Jul 18, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions