Repository navigation
Build failure on SmartOS (6.1) #8
Description
CI run: https://ci.nodejs.org/job/node-test-commit-smartos/9806/nodes=smartos15-64/console
LD_LIBRARY_PATH=/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/lib.host:/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src; dtrace -G -xnolibs -s src/node_provider.d "/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace.o" -o "/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_provider.o"
touch /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node_dtrace_provider.stamp
dtrace: failed to compile script src/v8ustack.d: line 377: failed to resolve V8DBG_CLASS_SHAREDFUNCTIONINFO__NAME__OBJECT: Unknown variable name
node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o' failed
make[2]: *** [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o] Error 1
/cc @nodejs/platform-smartos
Activity
geek commentedon Jun 23, 2017
@targos I'll take a look today
misterdjules commentedon Jun 23, 2017
@targos You can use the following patch to get passed the compilation error: https://github.com/proxy/gist.github.com/misterdjules/f0bc7b42de7f9ee72e9535f0ce361ea0. The patch itself is not correct though, in the sense that the function position and function names outputted by the DTrace ustack helper are not correct, but I would think it's fine for now. Is that a correct assumption?
[HACK] fix SmartOS compilation
targos commentedon Jun 26, 2017
@misterdjules It does not seem quite correct.
I applied your patch: 0bf3f91 and now the error is:
dtrace: failed to compile script src/v8ustack.d: line 458: failed to resolve V8DBG_SHAREDFUNCTION_FUNCTION_TOKEN_POSITION: Unknown variable nameCI run: https://ci.nodejs.org/job/node-test-commit-smartos/9836/nodes=smartos15-64/console
misterdjules commentedon Jun 26, 2017
@targos
My apologies, I had forgotten to update the gist with all my local changes. I did so now, and using that gist should now allow you to work around the build errors.
When is that version of V8 scheduled to be merged in master?
[HACK] fix SmartOS compilation
[HACK] fix SmartOS compilation
[HACK] fix SmartOS compilation
targos commentedon Jun 27, 2017
@misterdjules Thank you. V8 6.1 should be merged in early September.
[HACK] fix SmartOS compilation
98 remaining items
src: fix SmartOS compilation
[HACK] fix SmartOS compilation
src: fix SmartOS compilation
src: fix SmartOS compilation
[HACK] fix SmartOS compilation
src: fix SmartOS compilation
src: fix SmartOS compilation
src: fix SmartOS compilation
src: fix SmartOS compilation
src: fix SmartOS compilation
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR