Skip to content

Unhelpful error message when using unknown remote #701

Open
Open
Unhelpful error message when using unknown remote#701

Description

@anonrig
anonrig
opened on Jun 3, 2023

I'm receiving a weird error running the following command:

git node land 48272
Error: git config,--get,remote.remote-upstream.url failed with stderr:
    at runSync (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/lib/run.js:91:11)
    at new Session (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/lib/session.js:30:26)
    at new LandingSession (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/lib/landing_session.js:28:5)
    at main (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/components/git/land.js:167:17)

Activity

  1. aduh95 commented on Jun 3, 2023

    @aduh95
    aduh95
    on Jun 3, 2023
    Contributor

    Can you paste the result of cat .git/config please?

  2. anonrig commented on Jun 3, 2023

    @anonrig
    anonrig
    on Jun 3, 2023
    MemberAuthor
    cat .git/config
[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
	ignorecase = true
	precomposeunicode = true
[remote "origin"]
	url = git@github.com:anonrig/node.git
	fetch = +refs/heads/*:refs/remotes/origin/*

  3. aduh95 commented on Jun 3, 2023

    @aduh95
    aduh95
    on Jun 3, 2023
    Contributor

    You don't have a remote called remote-upstream, so ncu cannot read the URL associated with it. To fix the issue, you need to either create a remote remote-upstream, or change the .ncu/config file to use a different remote name (likely upstream).

  4. anonrig commented on Jun 3, 2023

    @anonrig
    anonrig
    on Jun 3, 2023
    MemberAuthor

    Ah, you're right. I've setup the NCU incorrectly. Thank you @aduh95

  5. anonrig
    closed this as completedon Jun 3, 2023

  6. aduh95 commented on Jun 3, 2023

    @aduh95
    aduh95
    on Jun 3, 2023
    Contributor

    We could still decide to change the default to be upstream rather than remote-upstream and/or improve the error message when the git config call fails to hint into what might be wrong.

  7. anonrig commented on Jun 3, 2023

    @anonrig
    anonrig
    on Jun 3, 2023
    MemberAuthor

    Definitely, that might be helpful, for cases like this.

  8. aduh95
    changed the title [-]`git node land xx` fails[/-] [+]Unhelpful error message when using unknown remote[/+] on Jun 3, 2023
  9. aduh95
    reopened this on Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions