You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 25, 2018. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 25, 2018. It is now read-only.
Docs seem to get truncated when viewing on the iPhone #92
The "Event:error" line is the last I can see in this page. It doesn't allow me to scroll any further. I've tried on Chrome and Safari on multiple iphones. Same behaviour.
Okay, this is reproduceable on saucelabs. I'll gather some more information and open a ticket on the main repo. Will close it then here. Good call @girishla
I tested on a real device and I can scroll all the way down - when I reach code blocks I have to stop scrolling and then resume it from a point that is not in the code block which is annoying.
I think this happens because the scrolling gets "stuck" on the code block - we can fix this by listening to the scroll event and handling this case.
Activity
eljefedelrodeodeljefe commentedon Mar 16, 2016
Can you send in a screenshot?
girishla commentedon Mar 16, 2016
The "Event:error" line is the last I can see in this page. It doesn't allow me to scroll any further. I've tried on Chrome and Safari on multiple iphones. Same behaviour.
eljefedelrodeodeljefe commentedon Mar 16, 2016
Interesting. Couldn't reproduce with with chrome's window size emulator, but will check it back at work against some devices.
eljefedelrodeodeljefe commentedon Mar 16, 2016
Okay, this is reproduceable on saucelabs. I'll gather some more information and open a ticket on the main repo. Will close it then here. Good call @girishla
girishla commentedon Mar 16, 2016
Great, ta
girishla commentedon Mar 16, 2016
will let you close this when appropriate.
benjamingr commentedon Mar 16, 2016
They're scrollable to the right and behave exactly like code comments in GitHub and StackOverflow. I think the current behavior is fine.
eljefedelrodeodeljefe commentedon Mar 16, 2016
Nah, he doesn't mean the codeblocks, but that you can't scroll past a certain point.
iOS 9.2, iPhone 6, process.html https://saucelabs.com/beta/tests/e2c86c418a5646bab619e9c4b4e2a6c7/watch
iOS 8.4, iPhone 6, stream.html https://saucelabs.com/beta/tests/fdc9c31581a24841bd8688555374f7f9/watch
iOS 9.2, iPhone 6, stream.html https://saucelabs.com/beta/tests/9e1d5547403b4ffd9f4f01ff9bf4d968/watch
benjamingr commentedon Mar 16, 2016
I tested on a real device and I can scroll all the way down - when I reach code blocks I have to stop scrolling and then resume it from a point that is not in the code block which is annoying.
I think this happens because the scrolling gets "stuck" on the code block - we can fix this by listening to the scroll event and handling this case.
eljefedelrodeodeljefe commentedon Mar 16, 2016
Could you be more precise please. Hardware, OS, Page? Because it's very easy to reproduce the faulty behaviour at sauce labs tbh.
benjamingr commentedon Mar 16, 2016
Sure - It's faulty, but I can scroll down. This is a real iPhone 6 with iOS 9.2 (haven't upgraded since).
stevemao commentedon Mar 16, 2016
I never had good experience viewing docs on my phone and I gave up... If there is any good third party docs viewer we could probably learn from it.
eljefedelrodeodeljefe commentedon Mar 23, 2016
Closed in favor for nodejs/node#5861 Thanks for reporting!
girishla commentedon Mar 23, 2016
Thanks for fixing!
Knighton910 commentedon Mar 23, 2016
+1