Upgrade openssl to 1.1.1g on ubuntu1804_sharedlibs_openssl111_x64 #2363

Activity

1. richardlau commented on Jun 22, 2020

   

   richardlau

   on Jun 22, 2020

   Member

   More actions

   Yes, it can. Relevant lines in ansible are

   build/ansible/roles/docker/templates/ubuntu1804_sharedlibs.Dockerfile.j2

   Lines 57 to 65 in d4b074c

   	ENV OPENSSL111DIR /opt/openssl-1.1.1b
   	RUN mkdir -p /tmp/openssl_1.1.1b && \
   	cd /tmp/openssl_1.1.1b && \
   	curl -sL https://www.openssl.org/source/openssl-1.1.1b.tar.gz | tar zxv --strip=1 && \
   	./config --prefix=$OPENSSL111DIR && \
   	make -j 6 && \
   	make install && \
   	rm -rf /tmp/openssl_1.1.1b

   PR's welcome 😄.
2. richardlau commented on Jun 22, 2020

   

   richardlau

   on Jun 22, 2020

   Member

   More actions

   (To clarify, the ansible template will first need to be updated and then one of https://github.com/nodejs/build#jenkins-admins will need to reansible the sharedlib containers.)
3. rvagg commented on Jun 23, 2020

   

   rvagg

   on Jun 23, 2020

   Member

   More actions

   I'll do it. May as well do Alpine 3.12 while I'm there.
4. rvagg commented on Jun 23, 2020

   

   rvagg

   on Jun 23, 2020

   Member

   More actions

   Upgraded to 1.1.1g, see #2364, but seeing failures on test-crypto-authenticated-stream on master, https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_openssl111_x64/20939/, so I don't think the problem is in nodejs/node#33981, it's on master already.
5. rvagg

   closed this as completedon Jun 23, 2020