Skip to content

Add linters #22

Open
Open

Description

@joyeecheung

I vaguely remember we published the linter rules that node.js core somewhere so that it can be reused through out the organizations. Though it's been too long since I added a new JS repo to the organization that needs it to know off the top of my head, we can probably just copy whatever https://github.com/nodejs/node-core-utils have.

Activity

  1. AugustinMauroy commented on Dec 14, 2024

    @AugustinMauroy
    Member

    on user-land migration and amaro we use biomejs

    so we can consider biomejs

  2. richardlau commented on Dec 14, 2024

    @richardlau
    Member

    There's https://github.com/nodejs/eslint-plugin-nodejs-internal but I'm not sure if it's being used anywhere.

  3. AugustinMauroy commented on Dec 14, 2024

    @AugustinMauroy
    Member

    There's https://github.com/nodejs/eslint-plugin-nodejs-internal but I'm not sure if it's being used anywhere.

    it's doesn't support eslint v9 ?
    is it still maintain ?

  4. AugustinMauroy commented on Dec 21, 2024

    @AugustinMauroy
    Member

    Which one should we take ?

  5. joyeecheung commented on Dec 21, 2024

    @joyeecheung
    MemberAuthor

    As long as it looks close enough to the styles used by Node.js core I think either eslint or biome works.

  6. AugustinMauroy commented on Dec 21, 2024

    @AugustinMauroy
    Member

    +1 for biome because it's FAST, have official GA with reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions