Repository navigation
Conversation
…ialogActions and AccordionDetails
11 of 37 tasks
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CardActions, DialogContent, DialogActions and AccordionDetails didn't support the
componentprop, while their siblings CardContent, DialogTitle and AccordionSummary do. Acomponentpassed to them was forwarded to the root<div>as an unknown attribute.They now render their root through
as={component}and are typed asOverridableComponent, following CardContent. Withcomponent="form", for example, TypeScript accepts form props such asonSubmit, which is a common need forDialogContentandDialogActionsinside a form dialog.XPropschanges from an interface to a type alias with optional generics, the same shape asCardContentProps, so existing uses ofCardActionsPropsand the others keep working.Part of #49337