Repository navigation
gha: retry temporary cache errors - #2911
Open
codeandsolder wants to merge 1 commit into
Open
codeandsolder wants to merge 1 commit into
codeandsolder wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
=======================================
Coverage 78.06% 78.07%
=======================================
Files 73 74 +1
Lines 43233 43272 +39
=======================================
+ Hits 33749 33783 +34
- Misses 9484 9489 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sylvestre
reviewed
Oct 18, 2026
| opendal = { version = "0.58.1", optional = true, default-features = false } | ||
| opendal-http-transport-reqwest = { version = "0.58.1", optional = true } | ||
| opendal-layer-logging = { version = "0.58.1", optional = true } | ||
| opendal-layer-retry = { version = "=0.58.1", optional = true } |
Collaborator
There was a problem hiding this comment.
why =0.58.1 here when the other opendal crates use 0.58.1?
sylvestre
reviewed
Oct 18, 2026
| .layer( | ||
| RetryLayer::new() | ||
| .with_jitter() | ||
| .with_max_times(6) |
Collaborator
There was a problem hiding this comment.
could you please add a one line comment on why 6 and 8s?
like: GitHub asks for Retry-After up to ~20s on 429
codeandsolder-git-wrangler
Bot
force-pushed
the
upstream-pr/gha-retry-temporary-errors
branch
from
October 18, 2026 20:10
81a8d4a to
d32c525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2821.
Summary
ghafeatureThe retry bounds follow the live
Retry-Afterbehavior reported in the issue while avoiding retries for persistent errors.Validation
--no-default-features --features ghacheckcargo fmt, locked dependency resolution, andgit diff --check