Repository navigation
s3: bump opendal to 0.59.4 to support S3 Express One Zone - #2902
Open
Kostoprav19 wants to merge 2 commits into
Open
Kostoprav19 wants to merge 2 commits into
Kostoprav19 wants to merge 2 commits into
Conversation
opendal 0.59.0 recognizes directory bucket names (`--x-s3` suffix), derives the zonal endpoint and defaults to the session signer for them (apache/opendal#8135), so bumping opendal and its split crates is enough: no change to how sccache builds the S3 operator is needed. Document that directory buckets work with plain SCCACHE_BUCKET. Fixes mozilla#2220
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
==========================================
- Coverage 78.27% 78.14% -0.13%
==========================================
Files 72 72
Lines 42123 42197 +74
==========================================
+ Hits 32970 32976 +6
- Misses 9153 9221 +68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sylvestre
reviewed
Oct 12, 2026
| - Optionally, `SCCACHE_ENDPOINT=<ip>:<port>` with a custom URL of a server you want a use, such as MinIO or DigitalOcean storage. | ||
| - `SCCACHE_S3_ENABLE_VIRTUAL_HOST_STYLE` to `true` if you are using a custom endpoint that supports virtual host style addressing. This is required for S3 transfer acceleration and some S3-compatible storage services. If you are using AWS S3, you can leave this unset. | ||
|
|
||
| S3 Express One Zone directory buckets (names ending in `--x-s3`) are supported as well: set `SCCACHE_BUCKET` to the directory bucket name and sccache uses the zonal endpoint and S3 Express session authentication automatically. |
Collaborator
There was a problem hiding this comment.
what happens if SCCACHE_ENDPOINT is set too? does it override the zonal endpoint?
if so, please mention to leave it unset
Author
There was a problem hiding this comment.
No — with a --x-s3 bucket opendal always sends requests to the zonal endpoint it derives from the bucket name; SCCACHE_ENDPOINT can’t override it.
opendal always sends directory bucket requests to the derived zonal endpoint; an explicit AWS endpoint is only validated against the bucket, and sccache defaults an unschemed SCCACHE_ENDPOINT to http, which that validation rejects. Say to leave it unset. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Author
|
@sylvestre can you help please - CodSpeed job failed with error code 143, but i have completely no visibility why. https://github.com/mozilla/sccache/actions/runs/38264728514/job/114964510974 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opendal 0.59.0 recognizes directory bucket names (
--x-s3suffix), derives the zonal endpoint and defaults to the session signer for them (apache/opendal#8135), so bumping opendal and its split crates is enough: no change to how sccache builds the S3 operator is needed.Document that directory buckets work with plain SCCACHE_BUCKET.
Fixes #2220