Repository navigation
Continue AppDB reconcile when Ops Manager returns 401 after a password change - #1716
Open
MaciejKaras wants to merge 4 commits into
Open
MaciejKaras wants to merge 4 commits into
MaciejKaras wants to merge 4 commits into
Conversation
Contributor
MCK 1.14.1 Release NotesBug Fixes
|
MaciejKaras
commented
Oct 19, 2026
MaciejKaras
commented
Oct 19, 2026
Collaborator
Author
|
evergreen retry |
MaciejKaras
marked this pull request as ready for review
October 19, 2026 13:45
seglo
removed their request for review
October 23, 2026 14:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the Application Database password is changed, Ops Manager keeps the old password until it is rolled and returns
401to the operator. The AppDB reconcile treated that401as a corrupted admin key and returned early with Ops ManagerFailed, which skipped publishing the new password to the AppDB and rolling Ops Manager. Ops Manager then kept failing with the old password and never recovered.The
401is still reported in the Ops Manager status, but the AppDB reconcile now continues.This also removes a dead
errcheck aftergenerateProcessHostnames. It re-used a staleerrfrom an earlier, only-logged Ops Manager call and reported it aserror getting current appdb statefulset hostnames, which is how a401from that call reached the early return. With the check gone, such a401no longer fails the reconcile; the early-return change covers401s returned by later calls (for example registering the AppDB hosts).Proof of Work
TestReconcileAppDB_DeploysAppDBWhenOpsManagerReturnsUnauthorizedinjects the401where the error is returned (GetHosts) and asserts the exact Ops Manager status (Failedwith the admin-key message) and that the AppDB StatefulSet is still created; the reachable case asserts an empty status. With the early return restored, the401case fails.controllers/operator/...andcontrollers/om/...pass.e2e_om_appdb_scramon the OM kind and multi-cluster variants passed (18 of 18 tasks, including build dependencies); a rerun with the final test passed too (18 of 18). The failure is a race, so one green run is supporting evidence only.evergreen:e2e-light(≈147 tasks) — operator change; light runse2e_om_appdb_scramon 8 variants. No OM-version-specific label, the change is version independent.Checklist