will there be a version for modx 3? #152
Description
Feature request
Summary
Quick summary what's this feature request about.
Why is it needed?
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Suggested solution(s)
A clear and concise description of what you want to happen.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request.
Activity
JoshuaLuckers commentedon May 4, 2021
Support for 3.x is a work in progress. Any help is welcome, you can use the develop branch to help test and submit issues and/or PR's!
rthrash commentedon Feb 15, 2022
This issue has been mentioned on MODX Community. There might be relevant details there:
https://community.modx.com/t/need-help-with-mystery-connector-500-error/4978/6
BobRay commentedon Feb 15, 2022
The error Ryan is talking about caused a completely empty resource tree. Commenting out the three "require_once" lines in the ArticlesContainer class fixed that (though Articles itself still doesn't work).
Mark-H commentedon Feb 15, 2022
That's probably been fixed with aaba113 but there hasn't been a release yet I think.
JoshuaLuckers commentedon Feb 15, 2022
Any help with testing the things that are already done in the develop branch that would be great! Especially for those upgrading from an existing installation with Articles. But always make a backup!
JoshuaLuckers commentedon Feb 16, 2022
I had some time today to look into 3.x compatibility. I pushed some changes to the develop branch, installing it in 3.x still gives some errors. Most likely related to the validators in
_build/resolvers/validators:If someone knows a fix for this, please feel free to submit a PR. Otherwise I'll look into it myself sometime in the upcoming week.
JoshuaLuckers commentedon Feb 20, 2022
Thanks to @Mark-H I've solved the issue with the resolvers and validators.
There is still some work to do:
extension_packagesis no longer being used in 3.xJoshuaLuckers commentedon Feb 20, 2022
The ArticlesContainer isn't recognized as Document Type yet. So I have to fix that as well.
Probably because the schema is still for 2.x, but I want to maintain backwards compatibility with 2.x without releasing a separate version for 3.x.
Any suggestions are welcome!
muzzwood commentedon Feb 23, 2022
Hey @JoshuaLuckers 👋🏻
I was playing around trying to get the Articles derivative modResource classes to be loaded in both 2.x and 3.x but haven't had much luck. 😅
It could be that having a separate version for 3.x is the easier (possible) path... if you're open to it?
The main consideration I think would be to make sure the current version doesn't cause any errors during an upgrade from MODX 2.x -> 3.x, and then the user would upgrade to the 3.x version via the package manager after the MODX upgrade is complete.
What do you reckon?
JoshuaLuckers commentedon Feb 23, 2022
@muzzwood Thanks a lot for taking time to help out!
That seems like a good enough solution for me!
muzzwood commentedon Feb 23, 2022
Awesome! I'll get a PR together for you ;)
muzzwood commentedon Feb 25, 2022
WIP draft is here #156
Can't be packaged yet but I hope to get that done later today.
JoshuaLuckers commentedon Mar 28, 2022
@muzzwood I've merged your PR. I'll try to update the changelog tomorrow and submit an alpha release of it.
BobRay commentedon Mar 28, 2022
Great work guys!
JoshuaLuckers commentedon Mar 30, 2022
Sorry guys I didn't manage to put out a new release. I hope to do it soon. @muzzwood but feel free to put out a new release if you have more time for it.
8 remaining items
muzzwood commentedon Apr 2, 2022
2.x package: #158
3.x package: #157
JoshuaLuckers commentedon Apr 5, 2022
Thanks to the amazing work of @muzzwood and sponsorship of modmore, I released an alpha release for Articles 2.0 with support for MODX 3.
HarveyEV commentedon Apr 6, 2022
I upgraded article to 1.8.0. then upgraded site to 3.0. Isee the 2.0 alpha package but cannot install it. Getting error Could not download and create transport package with signature: articles-2.0.0-alpha1
JoshuaLuckers commentedon Apr 6, 2022
That's odd, I'll investigate it.
You can try to download the package and install it manually: https://github.com/modxcms/Articles/blob/develop-3x/_packages/articles-2.0.0-alpha1.transport.zip
nsuomine commentedon Apr 7, 2022
I updated to 1.8.0 without issues. Thanks for good work.
Quip is quite often used with Articles. That prevents from upgrading to MODX3. Will Quip be made MODX3 compatible? Migrating to another commenting system is an option too but continueing to use use Quip would be the easiest solution.
muzzwood commentedon Apr 8, 2022
Quip still needs some tweaks to work fully (it gives errors in the log about modAction when running on MODX3).
@nsuomine if you're able to try upgrading a clone of your site to 3.0, and report any issues you face with Quip, I'd be happy to try solving them.
nsuomine commentedon Apr 8, 2022
@muzzwood Thanks for offering help.
Yes, Quip gives many warnings on 2.8.3 too but it still works. I understood that there is no more support for modAction in 3.0 so Quip would get broken? Do you think it would still work with the same warnings in the log.
muzzwood commentedon Apr 9, 2022
It may just be to do with the GetList processor. I think it mostly works already from what I saw working on Articles. Unfortunately I haven't used Quip in a long time, so really the best way would be to try updating a copy of a site that has Quip already installed and then see what fails.
I can see that modAction has been reported there for quite some time but let me know if anything else fails. ;)
nsuomine commentedon Apr 9, 2022
I don't have a test copy of the site. I could clone the site and database on my hosting provider but I should change database and the site URL of the clone. Is it enough to make changes only in the main config file of the clone?
Btw, are there any newer commenting extras available? Been looking for long but haven't found any as good as Quip.
muzzwood commentedon Apr 12, 2022
I think there's a bunch of SaaS solutions for commenting but Quip is probably best if you want complete control of the data.
Yeah best way to find out what works and what doesn't is just make a copy/export of your full site (files/db), install it elsewhere, then try upgrading it.
nsuomine commentedon Nov 5, 2022
I installed Quip on a MODX3 site to test if it works. It didn't.
My primary site is still running MODX2.8 and it is quite dependent on Quip. I would not like to replace Quip but it is preventing me to upgrade to MODX3. As far as I have seen, there is not much activity around Quip to make it MODX3 compatible.
muzzwood commentedon Nov 6, 2022
Unfortunately most developers usually have more work lined up than time available... and paid work usually takes precedence.
One way of getting developer(s) to work on it sooner than later could be to crowdfund it, similar to what's happening with VersionX at the moment:
modmore/VersionX#4 (comment)
nsuomine commentedon Nov 8, 2022
Yes, that's natural. Paid work first.
Crowdfunding is a good idea. Quip could be modernized, bugs fixed and features added. Not sure if there are enough users willing to pay.
An easier solution may be to use other PHP/Ajax-based open-source commenting tools. Quip would be the easiest solution, but it will take time even with crowdfunding. Quip is my only extra that is not well enough compatible with MODX3.
Mark-H commentedon Nov 23, 2022
Perhaps modernising Quip would be a good first use of the OpenCollective funds, though I have no idea how much work Quip would need. Probably better to discuss in the right repository too.
modxcommunity commentedon Jul 22, 2023
This issue has been mentioned on MODX Community. There might be relevant details there:
https://community.modx.com/t/quip-comment-not-posting-in-articles/6904/2