Repository navigation
[rel/17.6] Filter out known platform sources - #4517
Merged
Jakub Jareš (nohwnd) merged 2 commits intoJun 5, 2023
Merged
Jakub Jareš (nohwnd) merged 2 commits into
Jakub Jareš (nohwnd) merged 2 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When default assembly filter in azdo is used, which is test.dll, many of test platform own dlls are included, and when we don't exclude them they are misinterpreted as test assemblies, because we simply try to run whatever user gives us, no matter what the name is. Those dlls are using runnable tfm (e.g. netcoreapp3.1) so we don't know that they should be skipped, and they are not later filtered out by having a missing runtime provider. So these sources try to run, and will fail the run because they have missing runtime config or similar required files.
Related issue
Fix #4511