Repository navigation
Add letter number among valid identifiers in class name - #13868
Merged
Jakub Jareš (nohwnd) merged 4 commits intoJan 6, 2025
Merged
Jakub Jareš (nohwnd) merged 4 commits into
Jakub Jareš (nohwnd) merged 4 commits into
Conversation
Jakub Jareš (nohwnd)
requested a review
from Amaury Levé (Evangelink)
as a code owner
January 6, 2025 12:03
Amaury Levé (Evangelink)
approved these changes
Jan 6, 2025
…es/ManagedNameHelper.Reflection.cs Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…sses.cs Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…NameUtilities/ManagedNameGeneratorTests.cs Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
commented
Jan 6, 2025
Member
Author
|
Linked issue mentions that this is not functional issue, it just impacts the view. Do you have a reason why backporting would be worth it? |
commented
Jan 6, 2025
Member
|
The link wasn't opening for me (DNS issue) so I didn't see this was only a "view" issue. Thanks for the comment, please disregard my request/suggestion. |
This was referenced Jul 21, 2025
Closed
Merged
Closed
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Oct 16, 2026
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IsLetterOrDigit is not considering LetterNumbers to be a digit (as defined here in remarks: https://learn.microsoft.com/en-us/dotnet/api/system.char.isletterordigit?view=net-9.0 )
But spec considers them as valid, this mismatch was causing the identifier to be wrapped in
'.Related issue
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2285943