Repository navigation
Migrate Mocha and test configuration to v12 - #26194
Raymond Zhao (rzhao271) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
|
🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR. |
|
Result: Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: Dependency and test discovery, Default XML and real socket completion probe. The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: Offline dependency installation and TypeScript compilation passed. Targeted compiled-unit, TypeScript-unit, and functional runs passed with 4, 28, and 25 tests respectively; nested failures were intentional reporter fixtures. XML output precedence, default output, and PID-prefixed console reporting were verified. The socket-completion probe failed because my harness used Mocha’s module namespace as a constructor, not because of changed PR code. Actual socket notification after XML completion remains uncovered by the added regression tests, and Electron integration was not run. Test runs: 4 passed, 2 failed, 1 not run
|
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Upgrade Mocha to 12.0.2 using npm 11.19 with
--min-release-age 7.MOCHA_FILE.