Repository navigation
fix(firefox): disable safe mode keyboard shortcut in environment (#43089) - #43178
Merged
Pavel Feldman (pavelfeldman) merged 2 commits intoOct 8, 2026
Merged
Pavel Feldman (pavelfeldman) merged 2 commits into
Pavel Feldman (pavelfeldman) merged 2 commits into
Conversation
Member
|
Thanks for the fix. Since we don't test the actual hang, let's remove the test. |
Contributor
Author
|
Removed the test as requested. Thanks Pavel Feldman (@pavelfeldman)! |
Pavel Feldman (pavelfeldman)
approved these changes
Oct 7, 2026
Contributor
Test results for "tests 1"9 flaky52979 passed, 1270 skipped Merge workflow run. |
Contributor
Test results for "MCP"2 failed 9046 passed, 1495 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit Oct 8, 2026
1139417
into
microsoft:main
43 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43089 where launching Firefox (especially in headless mode) hangs if the
Shiftkey is pressed or held on Windows (orOptionkey on macOS), causing Firefox to trigger its modal Troubleshoot / Safe Mode prompt dialog (chrome://browser/content/safeMode.xhtml). In headless mode or automated launches, this modal prompt is invisible and cannot be dismissed, causinglaunchandlaunchPersistentContextto hang until timeout.What changed
packages/playwright-core/src/server/firefox/firefox.ts&bidiFirefox.ts'MOZ_DISABLE_SAFE_MODE_KEY': '1'toamendEnvironmentin both standard Firefox and BiDi Firefox launchers.'MOZ_DISABLE_SAFE_MODE_KEY': '1'before expanding...env, preserving user-configured environment overrides if explicitly provided.Test changes
tests/library/firefox/launcher.spec.ts'should disable safe mode key in firefox environment'verifying that:MOZ_DISABLE_SAFE_MODE_KEYis set to'1'by default inamendEnvironmentfor both Firefox and BiDi Firefox.envoverride the default.Verification
npm run buildcompleted successfully.npx playwright test tests/library/firefox/launcher.spec.ts -g "should disable safe mode key in firefox environment"passed.npm run tscpassed with 0 errors.npm run eslintpassed with 0 errors.Closes #43089