Skip to content

feat(reporter): report step params in the chrome://tracing report - #42358

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:chrome-trace-step-params
Aug 22, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:chrome-trace-step-params

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Summary

  • TestStep.params now land in the params trace event argument of the corresponding slice, so chrome://tracing shows the locator, url and test.step params next to each step.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Step params reported to the reporters land in the `params` trace event
argument of the corresponding slice.

Render the API call params through a class/method-aware switch keyed the
same way as the protocol metainfo, so that each call reports the
arguments that say what it did. Unbounded arguments are never reported
and long strings are truncated to keep the reports small.

Write the report event by event instead of serializing it into a single
string, and stream it through gzip when the output file ends with ".gz".
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/heap.spec.ts:223 › should not leak workers `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51370 passed, 1238 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [webkit] › mcp/cli-json.spec.ts:191 › tool error on bad navigation returns JSON error @mcp-macos-latest-webkit

8141 passed, 1361 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟡 One failure, but I can't tie it to this PR either way

[webkit] › mcp/cli-json.spec.ts:191 › tool error on bad navigation returns JSON error failed on mcp-macos-latest-webkit. This PR only touches the reporter, so the diff doesn't reach that test — but the test also has no failure history I can point to, so I'm calling it uncertain rather than a confirmed flake.

Details

The latest merged reports: tests 1 is clean (4 flaky, 0 failed) and MCP has a single failure. So there's one real failure to explain.

Uncertain

  • [webkit] › mcp/cli-json.spec.ts:191 › tool error on bad navigation returns JSON error (@mcp-macos-latest-webkit) — this PR changes only reporter code (chromeTrace.ts, index.ts reporter wiring, docs, and the reporter/step test-runner specs). None of that is exercised by an MCP CLI test that spawns the CLI and asserts on its JSON error output, so the diff can't plausibly reach it. But I can't confirm a flake either: across the aggregated CI results this test is 0 failures in 725 runs on mcp-macos-latest-webkit (and 700+ green on every other MCP bot), so there's no prior failure/flip to cite. Most likely one-off noise on the macOS runner, but unproven. To be sure I'd want to see whether it reproduces on a rerun of the MCP shard.

Flaky / infra

  • The tests 1 report lists only flaky retries (video.spec.ts:736, beforeunload.spec.ts:130, heap.spec.ts:223, page-event-request.spec.ts:181) — all passed on retry and none in code this reporter-only PR touches. Nothing to triage there.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit d4e1023 into microsoft:main Aug 22, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants