Repository navigation
Fix Twoslash popup stacking - #1946
Open
David Pine (IEvangelist) wants to merge 1 commit into
Open
David Pine (IEvangelist) wants to merge 1 commit into
David Pine (IEvangelist) wants to merge 1 commit into
Conversation
Raise the active code block while a Twoslash popup is open so following page content cannot paint over it. Add browser coverage for the Ollama reproduction in both themes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused lifecycle change handles overlapping popups correctly, with regression coverage and no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes Twoslash hover popups appearing behind following content on the documentation site.
Changes:
- Raises the active Expressive Code block while a popup is open and resets stacking after its last popup closes.
- Adds hover-initialization synchronization and browser coverage for the Ollama
withReferencereproduction in light and dark themes.
| File | Description |
|---|---|
src/frontend/tests/e2e/twoslash-navigation.spec.ts |
Adds initialization waits and popup stacking checks in both themes. |
src/frontend/src/scripts/twoslash-hover.ts |
Manages code-block stacking through the popup lifecycle. |
Review effort: Balanced
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Twoslash hover popups being visually covered by content following a code block.
withReferencereproduction in light and dark themes.Third-party links and affiliations
None
Validation
pnpm --dir .\src\frontend exec playwright test tests/e2e/twoslash-navigation.spec.ts --project=desktop-chromium --workers=1 --grep "paints popups"pnpm --dir .\src\frontend exec vitest run --config vitest.config.ts tests/unit/twoslash-hover-runtime.vitest.test.tspnpm --dir .\src\frontend exec eslint src/scripts/twoslash-hover.ts tests/e2e/twoslash-navigation.spec.ts --max-warnings 0git diff --check