Repository navigation
Python: Avoid generated executor ID collisions in declarative workflows - #9087
Draft
LI (ktz03) wants to merge 2 commits into
Draft
LI (ktz03) wants to merge 2 commits into
LI (ktz03) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused allocation changes and regression coverage support the fix, with no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes generated executor ID collisions in Python declarative workflows while preserving authored IDs and existing noncolliding IDs.
Changes:
- Reserve nested authored executor IDs before graph construction.
- Allocate deterministic unused IDs for generated actions and control-flow helpers.
- Add regressions for collisions, routing, loop references, and compatibility.
| File | Description |
|---|---|
python/packages/declarative/tests/test_workflow_generated_ids.py |
Adds collision and compatibility regression tests. |
python/packages/declarative/agent_framework_declarative/_workflows/_declarative_builder.py |
Reserves authored IDs and allocates collision-free generated IDs. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Valid Python declarative action definitions fail to build when an unnamed action or a control-flow helper generates the same executor ID as an authored action. For example, an unnamed first
SendActivityand a later action explicitly namedSendActivity_0raise a duplicate executor error.Description & Review Guide
Related Issue
Fixes #9086
Related design review: #8161 (the broader review is not closed by this change).
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.