Repository navigation
Python: Fix quoted arguments in declarative concatenation - #9073
Open
LI (ktz03) wants to merge 1 commit into
Open
LI (ktz03) wants to merge 1 commit into
LI (ktz03) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation correctly addresses the reported cases with comprehensive regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes declarative concatenation so complete PowerFx string literals are decoded correctly while compound expressions are evaluated normally.
Changes:
- Recognizes complete quoted literals and decodes doubled quotes.
- Adds workflow and engine-unavailable regression coverage for both aliases.
| File | Description |
|---|---|
_declarative_base.py |
Corrects concatenation argument evaluation. |
test_graph_workflow_integration.py |
Adds workflow-level regression cases. |
test_graph_executors.py |
Verifies literal concatenation without PowerFx. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Declarative string concatenation currently treats any argument beginning and ending with a double quote as a literal.
Concatenate("a" & "b", "c")consequently emitsa" & "bcinstead ofabc, andConcatenate("a""b", "c")leaves the escaped quote doubled. This can put formula source into a workflow's rendered activity.Description & Review Guide
Concatalias and existing single-quoted compatibility path are preserved.MessageText, missing-value handling, and the engine-independent literal path.Related Issue
Fixes #9072
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and the title prefix in sync automatically.