Repository navigation
Remove unnecessary explicit override - #6664
Open
Trung Nguyen (trungnt2910) wants to merge 1 commit into
Open
Trung Nguyen (trungnt2910) wants to merge 1 commit into
Trung Nguyen (trungnt2910) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
Contributor
|
This PR has been open for 30 days. Are you still interested in merging this PR? If so, please make sure your branch is up to date with the latest |
Since `IResourceLinkBuilder` is the only base of `PriSectionBuilder` that defines `GetSchema()`, the explicit qualifier is redundant. Removing this MSVC-specific feature also allows MRTCore to be built with Clang and MinGW.
Trung Nguyen (trungnt2910)
force-pushed
the
patch-2
branch
from
October 16, 2026 00:25
8e6ed98 to
3cecc62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
IResourceLinkBuilderis the only base ofPriSectionBuilderthat definesGetSchema(), the explicit qualifier is redundant.Removing this MSVC-specific feature also allows MRTCore to be built with Clang and MinGW.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.