Skip to content

Update singleCompilation flag name to isolatedModules - #3208

Merged
Mohamed Hegazy (mhegazy) merged 2 commits into
release-1.5from
updateSingleCompilationFlagName
May 19, 2015
Merged

Mohamed Hegazy (mhegazy) merged 2 commits into
release-1.5from
updateSingleCompilationFlagName

Conversation

@mhegazy

Copy link
Copy Markdown
Contributor

No description provided.

@paulvanbrenk

Copy link
Copy Markdown
Contributor

👍

@DanielRosenwasser

Copy link
Copy Markdown
Member

Are we sure we want isolatedModules and not isolatedModule?

@yuit

Copy link
Copy Markdown
Contributor

lgtm. though agree with Daniel Rosenwasser (@DanielRosenwasser)'s question. I have slight preference with isolatedModule

Mohamed Hegazy (mhegazy) added a commit that referenced this pull request May 19, 2015
Update singleCompilation flag name to isolatedModules
@mhegazy
Mohamed Hegazy (mhegazy) merged commit 5ea2cea into release-1.5 May 19, 2015
@mhegazy
Mohamed Hegazy (mhegazy) deleted the updateSingleCompilationFlagName branch May 19, 2015 20:55
@mhegazy

Copy link
Copy Markdown
Contributor Author

the idea is you would use this with in a normal compilation, with multiple files, to ensure you can do the compile them in isolation later, hence the "s".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants