Skip to content

[type bug] fontfaces property is missing from loadingdone event object #51885

Closed
Closed
[type bug] fontfaces property is missing from loadingdone event object#51885
Labels
BugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issueHelp WantedYou can do this
Milestone
Backlog

Description

@TechQuery
South Drifter (TechQuery)
opened on Dec 14, 2022

Configuration Check

My compilation target is ES2015 and my lib is ES2022 & `DOM.

Missing / Incorrect Definition

Request to replace the event type of onloadingdone handler from Event to FontFaceSetLoadEvent, which has been defined in the same module.

TypeScript/lib/lib.dom.d.ts

Line 5530 in eb9252e

onloadingdone: ((this: FontFaceSet, ev: Event) => any) | null;

TypeScript/lib/lib.dom.d.ts

Lines 5548 to 5550 in eb9252e

interface FontFaceSetLoadEvent extends Event {
readonly fontfaces: ReadonlyArray<FontFace>;
}

Sample Code

interface FontFaceSet extends EventTarget {
-    onloadingdone: ((this: FontFaceSet, ev: Event) => any) | null;
+    onloadingdone: ((this: FontFaceSet, ev: FontFaceSetLoadEvent) => any) | null;
}

Documentation Link

https://w3c.github.io/csswg-drafts/css-font-loading/#FontFaceSet-events

Activity

  1. Ryan Cavanaugh (RyanCavanaugh)
    added
    BugA bug in TypeScript
    Help WantedYou can do this
    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScript
    on Dec 15, 2022
  2. Ryan Cavanaugh (RyanCavanaugh)
    added this to the Backlog milestone on Dec 15, 2022

  3. RyanCavanaugh commented on Sep 18, 2026

    @RyanCavanaugh
    Ryan Cavanaugh (RyanCavanaugh)
    on Sep 18, 2026
    Member

    Fixed by PR #60061. With --target es2015 --lib es2022,dom, TypeScript 5.7.0-dev.20240927 reports TS2339 because onloadingdone receives Event; 5.7.0-dev.20240928 and current TypeScript type the event as FontFaceSetLoadEvent, so event.fontfaces is available.

  4. Ryan Cavanaugh (RyanCavanaugh)
    added
    FixedA PR has been merged for this issue
    Needs Human ReviewThis issue has a backlog check awaiting maintainer review.
    on Sep 18, 2026
  5. Ryan Cavanaugh (RyanCavanaugh)
    closed this as completedon Sep 18, 2026

  6. TechQuery commented on Sep 19, 2026

    @TechQuery
    South Drifter (TechQuery)
    on Sep 19, 2026
    Author

    Fixed by PR #60061. With --target es2015 --lib es2022,dom, TypeScript 5.7.0-dev.20240927 reports TS2339 because onloadingdone receives Event; 5.7.0-dev.20240928 and current TypeScript type the event as FontFaceSetLoadEvent, so event.fontfaces is available.

    Thanks! Which version will this fixing be released in? 7.1.x, 6.x, or 5.9.x?

  7. RyanCavanaugh commented on Sep 24, 2026

    @RyanCavanaugh
    Ryan Cavanaugh (RyanCavanaugh)
    on Sep 24, 2026
    Member

    That PR shipped in 5.7 or 5.8

  8. Ryan Cavanaugh (RyanCavanaugh)
    removed
    Needs Human ReviewThis issue has a backlog check awaiting maintainer review.
    on Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issueHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions